Skip to content

Commit 6e2122d

Browse files
PR remarks fixes
1 parent ee2ddef commit 6e2122d

File tree

2 files changed

+23
-10
lines changed

2 files changed

+23
-10
lines changed

.github/workflows/continuous-integration-workflow.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,16 @@ jobs:
140140
test_dir: tests
141141
speculos_app_branch_name: ${{ github.ref }}
142142

143+
package_and_test_docker_for_nanos:
144+
name: Build and test the Speculos docker for Nano S
145+
uses: ./.github/workflows/reusable_ragger_tests_latest_speculos.yml
146+
needs: [package_and_test_docker]
147+
with:
148+
app_repository: LedgerHQ/app-boilerplate
149+
app_branch_name: nanos_baseline
150+
test_dir: tests
151+
speculos_app_branch_name: ${{ github.ref }}
152+
143153
deploy_docker:
144154
name: Build and Upload the Speculos docker
145155
runs-on: ubuntu-latest

.github/workflows/reusable_ragger_tests_latest_speculos.yml

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
with:
2727
app_repository: ${{ inputs.app_repository }}
2828
app_branch_name: ${{ inputs.app_branch_name }}
29-
upload_app_binaries_artifact: "compiled_app_binaries"
29+
upload_app_binaries_artifact: compiled_app_binaries-${{ inputs.app_repository }}-${{ inputs.app_branch_name }}
3030

3131
build_docker_image:
3232
name: Build Speculos Docker image
@@ -57,19 +57,22 @@ jobs:
5757
name: speculos_image
5858
path: /tmp/speculos_image.tar
5959

60+
call_get_app_metadata:
61+
name: Retrieve application metadata
62+
uses: LedgerHQ/ledger-app-workflows/.github/workflows/_get_app_metadata.yml@v1
63+
with:
64+
app_repository: ${{ inputs.app_repository }}
65+
app_branch_name: ${{ inputs.app_branch_name }}
66+
6067
ragger_tests:
6168
name: Functional tests with Ragger
6269
runs-on: ubuntu-latest
63-
needs: [build_docker_image, build_application]
70+
needs: [build_docker_image, build_application, call_get_app_metadata]
6471
strategy:
6572
fail-fast: false
6673
matrix:
67-
include:
68-
- device: nanos
69-
- device: nanox
70-
- device: nanosp
71-
- device: stax
72-
- device: flex
74+
device: ${{ fromJSON(needs.call_get_app_metadata.outputs.compatible_devices) }}
75+
7376
steps:
7477
- name: Clone
7578
uses: actions/checkout@v4
@@ -83,7 +86,7 @@ jobs:
8386
uses: actions/checkout@v4
8487
with:
8588
repository: ${{ inputs.app_repository }}
86-
ref: ${{ matrix.device == 'nanos' && 'nanos_baseline' || inputs.app_branch_name }}
89+
ref: ${{ inputs.app_branch_name }}
8790
path: app
8891
submodules: recursive
8992
fetch-depth: 0
@@ -105,7 +108,7 @@ jobs:
105108
- name: Download app binaries
106109
uses: actions/download-artifact@v4
107110
with:
108-
name: "compiled_app_binaries"
111+
name: compiled_app_binaries-${{ inputs.app_repository }}-${{ inputs.app_branch_name }}
109112
path: ${{ github.workspace }}/app/build
110113

111114
- name: Run and test Speculos docker

0 commit comments

Comments
 (0)