fixed bug with modifying hidden things

Legitcode · Sep 24, 2015 · 42dad57 · 42dad57
1 parent eba464c
commit 42dad57
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/README.md b/README.md
@@ -45,7 +45,6 @@ Optionally, use `modifyAll` to change every item.
 ~~~js
 
 modifyId({hidden, value, key, row}){
-  //row is the current row object
   return <a href={value}>{value}</a>
 }
 
@@ -70,10 +69,11 @@ modifyAll={this.modify}
 ###hide
 
 ```js
-let modify = ({hidden}) => {
-    expect(hidden.id).to.be.equal(1)
+let modify = ({hidden, value}) => {
+  expect(hidden.id).to.be.equal(1)
+  return value
 }
-Test(<Table rows={[{id: 1, name: 'zach'}]} hide={['id']}/>)
+Test(<Table rows={[{id: 1, name: 'zach'}]} hide={['id']} modifyAll={modify}/>)
 .find('td')
 .element(td => {
   expect(td.props.children).to.be.equal('zach');

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-legit-table",
-  "version": "0.4.0",
+  "version": "0.4.1",
   "description": "the simplest table component out there",
   "main": "lib/table.js",
   "scripts": {

diff --git a/tests/table.jsx b/tests/table.jsx
@@ -75,10 +75,11 @@ describe('Table component', () => {
     })
 
     it('should hide id row', () => {
-      let modify = ({hidden}) => {
-          expect(hidden.id).to.be.equal(1)
+      let modify = ({hidden, value}) => {
+        expect(hidden.id).to.be.equal(1)
+        return value
       }
-      Test(<Table rows={[{id: 1, name: 'zach'}]} hide={['id']}/>)
+      Test(<Table rows={[{id: 1, name: 'zach'}]} hide={['id']} modifyAll={modify}/>)
       .find('td')
       .element(td => {
         expect(td.props.children).to.be.equal('zach');