Skip to content

Commit b119273

Browse files
committed
Update Translation History
1 parent 32842ac commit b119273

File tree

4 files changed

+15
-3
lines changed

4 files changed

+15
-3
lines changed

functions/src/models/translation-history.model.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,7 @@ export enum TranslationHistoryType {
77
export interface TranslationHistory {
88
type: TranslationHistoryType;
99
description?: string;
10+
name?: string;
11+
email?: string;
1012
createdAt: Timestamp;
1113
}

functions/src/translations.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ import { findSpaceById, findTranslations, findTranslationsHistory } from './serv
1212
const translationsPublish = onCall<PublishTranslationsData>(async request => {
1313
logger.info('[translationsPublish] data: ' + JSON.stringify(request.data));
1414
logger.info('[translationsPublish] context.auth: ' + JSON.stringify(request.auth));
15-
const { spaceId } = request.data;
15+
const {auth, data } = request
16+
const { spaceId } = data;
1617
if (!canPerform(UserPermission.TRANSLATION_PUBLISH, request.auth)) throw new HttpsError('permission-denied', 'permission-denied');
1718
const spaceSnapshot = await findSpaceById(spaceId).get();
1819
const translationsSnapshot = await findTranslations(spaceId).get();
@@ -46,6 +47,8 @@ const translationsPublish = onCall<PublishTranslationsData>(async request => {
4647
await bucket.file(`spaces/${spaceId}/translations/cache.json`).save('');
4748
const addHistory: WithFieldValue<TranslationHistory> = {
4849
type: TranslationHistoryType.PUBLISHED,
50+
name: auth?.token['name'] || FieldValue.delete(),
51+
email: auth?.token.email || FieldValue.delete(),
4952
createdAt: FieldValue.serverTimestamp(),
5053
};
5154
await findTranslationsHistory(spaceId).add(addHistory);

src/app/features/translations/translations.component.html

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -345,10 +345,15 @@
345345
</div>
346346
<div class="flex min-w-0 flex-1 justify-between space-x-4 pt-1.5">
347347
<div>
348-
<p class="text-sm text-gray-500">Published</p>
348+
<p class="text-sm text-gray-500">
349+
Published by
350+
<span class="font-medium text-gray-900" [matTooltip]="item.email || 'Unknown'">
351+
{{ item.name || 'Unknown' }}
352+
</span>
353+
</p>
349354
</div>
350355
<div class="whitespace-nowrap text-right text-sm text-gray-500">
351-
<time datetime="2020-09-20">{{ item.createdAt?.toDate() | date: 'MMM dd, HH:mm' }}</time>
356+
<time>{{ item.createdAt?.toDate() | date: 'MMM dd, HH:mm' }}</time>
352357
</div>
353358
</div>
354359
}

src/app/shared/models/translation-history.model.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,7 @@ export interface TranslationHistory {
88
id: string;
99
type: TranslationHistoryType;
1010
description?: string;
11+
name?: string;
12+
email?: string;
1113
createdAt: Timestamp;
1214
}

0 commit comments

Comments
 (0)