remove ArrayBuffer in favor of Buffer (#85)

Author: vweevers

README.md

@@ -12,7 +12,7 @@ level.js uses [IDBWrapper](https://github.com/jensarps/IDBWrapper) by jensarps t
 
 Here are the goals of this level.js:
 
-- Store large amounts of ascii (strings, JSON) and binary (ArrayBuffers, Typed Arrays) data in modern browsers
+- Store large amounts of ascii (strings, JSON) and binary (Buffer) data in modern browsers
 - Be as fast as possible
 - Use the leveldown test suite and sync with [multilevel](https://github.com/juliangruber/multilevel) over either ascii or binary transports (websockets and xhr both have ascii/binary modes in browsers now)
 
@@ -44,8 +44,6 @@ The test suite for this library is in the [abstract-leveldown](https://github.co
 
 For more code examples see the [abstract-leveldown test suite](https://github.com/rvagg/node-abstract-leveldown/tree/master/abstract)
 
-The only differences between this and leveldown is that you can store `ArrayBuffers` in this (whereas leveldown just uses node `Buffer` objects)
-
 ## run the tests
 
 ```sh

index.js

@@ -4,7 +4,6 @@ var IDB = require('idb-wrapper')
 var AbstractLevelDOWN = require('abstract-leveldown').AbstractLevelDOWN
 var util = require('util')
 var Iterator = require('./iterator')
-var isBuffer = require('isbuffer')
 var xtend = require('xtend')
 var toBuffer = require('typedarray-to-buffer')
 
@@ -80,15 +79,12 @@ Level.prototype._put = function (key, value, options, callback) {
 // - Number, except NaN. Includes Infinity and -Infinity
 // - Date, except invalid (NaN)
 // - String
-// - ArrayBuffer or a view thereof (typed arrays)
+// - ArrayBuffer or a view thereof (typed arrays). In level-js we only support
+//   Buffer (which is an Uint8Array).
 // - Array, except cyclical and empty (e.g. Array(10)). Elements must be valid
 //   types themselves.
 Level.prototype._serializeKey = function (key) {
-  // TODO: do we still need to support ArrayBuffer?
-  if (key instanceof ArrayBuffer) {
-    key = Buffer.from(key)
-    return Level.binaryKeys ? key : key.toString()
-  } else if (Buffer.isBuffer(key)) {
+  if (Buffer.isBuffer(key)) {
     return Level.binaryKeys ? key : key.toString()
   } else if (Array.isArray(key)) {
     return key.map(this._serializeKey, this)
@@ -100,11 +96,7 @@ Level.prototype._serializeKey = function (key) {
 }
 
 Level.prototype._serializeValue = function (value) {
-  // TODO: do we still need to support ArrayBuffer?
-  if (value instanceof ArrayBuffer) return Buffer.from(value)
-  if (value == null) return ''
-
-  return value
+  return value == null ? '' : value
 }
 
 Level.prototype._iterator = function (options) {
@@ -159,16 +151,3 @@ Level.destroy = function (db, callback) {
     callback(err)
   }
 }
-
-var checkKeyValue = Level.prototype._checkKeyValue = function (obj, type) {
-  if (obj === null || obj === undefined)
-    return new Error(type + ' cannot be `null` or `undefined`')
-  if (obj === null || obj === undefined)
-    return new Error(type + ' cannot be `null` or `undefined`')
-  if (isBuffer(obj) && obj.byteLength === 0)
-    return new Error(type + ' cannot be an empty ArrayBuffer')
-  if (String(obj) === '')
-    return new Error(type + ' cannot be an empty String')
-  if (obj.length === 0)
-    return new Error(type + ' cannot be an empty Array')
-}

package.json

@@ -28,7 +28,6 @@
   "dependencies": {
     "abstract-leveldown": "~5.0.0",
     "idb-wrapper": "^1.5.0",
-    "isbuffer": "~0.0.0",
     "ltgt": "^2.1.2",
     "typedarray-to-buffer": "~3.1.5",
     "xtend": "~4.0.1"