split sync and async serve

Author: saviorand

bench.mojo

@@ -15,7 +15,7 @@ fn main():
     try:
         var server = SysServer()
         let handler = TechEmpowerRouter()
-        server.listen_and_serve("0.0.0.0:8080", handler)
+        server.listen_and_serve_async("0.0.0.0:8080", handler)
     except e:
         print("Error starting server: " + e.__str__())
         return

lightbug_http/sys/net.mojo

@@ -61,7 +61,7 @@ struct SysListener(Listener):
         self.__addr = addr
         self.fd = fd
 
-    @always_inline
+    # @always_inline
     fn accept[T: Connection](self) raises -> T:
         let their_addr_ptr = Pointer[sockaddr].alloc(1)
         var sin_size = socklen_t(sizeof[socklen_t]())

lightbug_http/sys/server.mojo

@@ -55,8 +55,19 @@ struct SysServer:
         let listener = __net.listen(NetworkType.tcp4.value, address)
         self.serve(listener, handler)
 
-    fn serve[T: HTTPService](inout self, ln: SysListener, handler: T) raises -> None:
+    fn listen_and_serve_async[
+        T: HTTPService
+    ](inout self, address: String, handler: T) raises -> None:
+        var __net = SysNet()
+        let listener = __net.listen(NetworkType.tcp4.value, address)
+        self.serve_async(listener, handler)
+
+    fn serve_async[
+        T: HTTPService
+    ](inout self, ln: SysListener, handler: T) raises -> None:
         self.ln = ln
+        # let max_worker_count = self.get_concurrency()
+        # TODO: logic for non-blocking read and write here, see for example https://github.com/valyala/fasthttp/blob/9ba16466dfd5d83e2e6a005576ee0d8e127457e2/server.go#L1789
 
         async fn handle_connection(conn: SysConnection, handler: T) -> None:
             var buf = Bytes()
@@ -126,41 +137,38 @@ struct SysServer:
             let coroutine: Coroutine[NoneType] = handle_connection(conn, handler)
             _ = coroutine()  # Execute the coroutine synchronously
 
-    # fn serve[T: HTTPService](inout self, ln: SysListener, handler: T) raises -> None:
-    #     # let max_worker_count = self.get_concurrency()
-    #     # TODO: logic for non-blocking read and write here, see for example https://github.com/valyala/fasthttp/blob/9ba16466dfd5d83e2e6a005576ee0d8e127457e2/server.go#L1789
-
-    #     self.ln = ln
-
-    #     while True:
-    #         let conn = self.ln.accept[SysConnection]()
-    #         var buf = Bytes()
-    #         let read_len = conn.read(buf)
-    #         let first_line_and_headers = next_line(buf)
-    #         let request_line = first_line_and_headers.first_line
-    #         let rest_of_headers = first_line_and_headers.rest
-
-    #         var uri = URI(request_line)
-    #         try:
-    #             uri.parse()
-    #         except:
-    #             conn.close()
-    #             raise Error("Failed to parse request line")
-
-    #         var header = RequestHeader(buf)
-    #         try:
-    #             header.parse()
-    #         except:
-    #             conn.close()
-    #             raise Error("Failed to parse request header")
-
-    #         let res = handler.func(
-    #             HTTPRequest(
-    #                 uri,
-    #                 buf,
-    #                 header,
-    #             )
-    #         )
-    #         let res_encoded = encode(res)
-    #         _ = conn.write(res_encoded)
-    #         conn.close()
+    fn serve[T: HTTPService](inout self, ln: SysListener, handler: T) raises -> None:
+        self.ln = ln
+
+        while True:
+            let conn = self.ln.accept[SysConnection]()
+            var buf = Bytes()
+            let read_len = conn.read(buf)
+            let first_line_and_headers = next_line(buf)
+            let request_line = first_line_and_headers.first_line
+            let rest_of_headers = first_line_and_headers.rest
+
+            var uri = URI(request_line)
+            try:
+                uri.parse()
+            except:
+                conn.close()
+                raise Error("Failed to parse request line")
+
+            var header = RequestHeader(buf)
+            try:
+                header.parse()
+            except:
+                conn.close()
+                raise Error("Failed to parse request header")
+
+            let res = handler.func(
+                HTTPRequest(
+                    uri,
+                    buf,
+                    header,
+                )
+            )
+            let res_encoded = encode(res)
+            _ = conn.write(res_encoded)
+            conn.close()