always log internal server error

Author: saviorand

README.md

@@ -97,25 +97,22 @@ Once you have a Mojo project set up locally,
    For example, to make a `Printer` service that prints some details about the request to console:
 
    ```mojo
-    from lightbug_http import *
+    from lightbug_http.http import HTTPRequest, HTTPResponse, OK
+    from lightbug_http.strings import to_string
+    from lightbug_http.header import HeaderKey
 
     @value
     struct Printer(HTTPService):
         fn func(mut self, req: HTTPRequest) raises -> HTTPResponse:
-            var uri = req.uri
-            print("Request URI: ", to_string(uri.request_uri))
-
-            var header = req.headers
-            print("Request protocol: ", req.protocol)
-            print("Request method: ", req.method)
-            print(
-                "Request Content-Type: ", to_string(header[HeaderKey.CONTENT_TYPE])
-            )
-
-            var body = req.body_raw
-            print("Request Body: ", to_string(body))
-
-            return OK(body)
+            print("Request URI:", req.uri.request_uri)
+            print("Request protocol:", req.protocol)
+            print("Request method:", req.method)
+            if HeaderKey.CONTENT_TYPE in req.headers:
+                print("Request Content-Type:", req.headers[HeaderKey.CONTENT_TYPE])
+            if req.body_raw:
+                print("Request Body:", to_string(req.body_raw))
+
+            return OK(req.body_raw)
    ```
 
 6. Start a server listening on a port with your service like so.

lightbug_http/server.mojo

@@ -161,14 +161,15 @@ struct Server(Movable):
             var response: HTTPResponse
             try:
                 response = handler.func(request)
-            except:
+            except e:
+                logger.error("Unexpected error in the handler:", e)
+
                 if not conn.is_closed():
                     # Try to send back an internal server error, but always attempt to teardown the connection.
                     try:
                         # TODO: Move InternalError response to an alias when Mojo can support Dict operations at compile time. (@thatstoasty)
                         _ = conn.write(encode(InternalError()))
                     except e:
-                        logger.error(e)
                         raise Error("Failed to send InternalError response")
                     finally:
                         conn.teardown()

lightbug_http/service.mojo

@@ -15,8 +15,10 @@ struct Printer(HTTPService):
         print("Request URI:", req.uri.request_uri)
         print("Request protocol:", req.protocol)
         print("Request method:", req.method)
-        print("Request Content-Type:", req.headers[HeaderKey.CONTENT_TYPE])
-        print("Request Body:", to_string(req.body_raw))
+        if HeaderKey.CONTENT_TYPE in req.headers:
+            print("Request Content-Type:", req.headers[HeaderKey.CONTENT_TYPE])
+        if req.body_raw:
+            print("Request Body:", to_string(req.body_raw))
 
         return OK(req.body_raw)