Skip to content

Commit f4694d5

Browse files
committed
mail: fix no owner error, log publish mail
Signed-off-by: Pamfilos Fokianos <[email protected]>
1 parent dd80115 commit f4694d5

File tree

1 file changed

+13
-5
lines changed

1 file changed

+13
-5
lines changed

cap/modules/mail/utils.py

Lines changed: 13 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -89,13 +89,19 @@ def add_hypernews_mail_to_recipients(recipients, cadi_id):
8989

9090

9191
def get_review_recipients(deposit, host_url, config):
92-
# mail of owner
93-
owner = deposit["_deposit"]["owners"][0]
94-
owner_mail = User.query.filter_by(id=owner).one().email
95-
9692
# mail of reviewer
9793
reviewer_mail = current_user.email
98-
recipients = [owner_mail, reviewer_mail]
94+
recipients = [reviewer_mail, ]
95+
96+
# mail of owner
97+
# owners = deposit.get("_deposit", {}).get("owners")
98+
owner_mail = "-"
99+
try:
100+
owner = deposit["_deposit"]["owners"][0]
101+
owner_mail = User.query.filter_by(id=owner).one().email
102+
recipients.append(owner_mail)
103+
except IndexError:
104+
pass
99105

100106
cadi_id = deposit.get("analysis_context", {}).get("cadi_id")
101107
if cadi_id:
@@ -234,6 +240,8 @@ def send_mail_on_publish(recid, revision,
234240
send_mail_on_hypernews(recipients, subject, message)
235241
send_mail_on_jira(recid, host_url, recipients, message, subject, template)
236242

243+
current_app.logger.info(
244+
f'Publish mail: {recid} - {", ".join(recipients)}.')
237245
create_and_send.delay(
238246
template,
239247
dict(recid=recid, url=host_url, message=message),

0 commit comments

Comments
 (0)