Skip to content

Commit 372bec1

Browse files
author
kvn
committed
8191788: add jdk.internal.vm.compiler to --limit-modules if -Djvmci.Compiler=graal is in the command line
Summary: skip tests which use --limit-modules when Graal is used as JIT compiler. Reviewed-by: alanb, mchung, dholmes, ccheung, dnsimon
1 parent a447e9b commit 372bec1

File tree

21 files changed

+28
-12
lines changed

21 files changed

+28
-12
lines changed

.hgignore

+2
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,5 @@ nbproject/private/
1111
test/nashorn/script/external
1212
test/nashorn/lib
1313
NashornProfile.txt
14+
.*/JTreport/.*
15+
.*/JTwork/.*

test/hotspot/jtreg/runtime/SharedArchiveFile/BootAppendTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323

2424
/**
2525
* @test
26-
* @requires vm.cds
26+
* @requires vm.cds & !vm.graal.enabled
2727
* @summary Testing -Xbootclasspath/a support for CDS
2828
* @requires (vm.opt.UseCompressedOops == null) | (vm.opt.UseCompressedOops == true)
2929
* @library /test/lib

test/hotspot/jtreg/runtime/appcds/jigsaw/JigsawOptionsCombo.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
* @summary Test combinations of jigsaw options that affect the use of AppCDS
2828
*
2929
* AppCDS does not support uncompressed oops
30-
* @requires (vm.opt.UseCompressedOops == null) | (vm.opt.UseCompressedOops == true)
30+
* @requires ((vm.opt.UseCompressedOops == null) | (vm.opt.UseCompressedOops == true)) & !vm.graal.enabled
3131
* @library /test/lib ..
3232
* @modules java.base/jdk.internal.misc
3333
* java.management

test/hotspot/jtreg/runtime/appcds/jigsaw/classpathtests/BootAppendTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
/**
2626
* @test
2727
* @summary AppCDS tests for testing -Xbootclasspath/a
28-
* @requires (vm.opt.UseCompressedOops == null) | (vm.opt.UseCompressedOops == true)
28+
* @requires ((vm.opt.UseCompressedOops == null) | (vm.opt.UseCompressedOops == true)) & !vm.graal.enabled
2929
* @library /test/lib /test/hotspot/jtreg/runtime/appcds
3030
* @modules java.base/jdk.internal.misc
3131
* java.management

test/hotspot/jtreg/runtime/appcds/jigsaw/classpathtests/ClassPathTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424

2525
/**
2626
* @test
27-
* @requires (vm.opt.UseCompressedOops == null) | (vm.opt.UseCompressedOops == true)
27+
* @requires ((vm.opt.UseCompressedOops == null) | (vm.opt.UseCompressedOops == true)) & !vm.graal.enabled
2828
* @library ../..
2929
* @library /test/lib
3030
* @modules java.base/jdk.internal.misc

test/hotspot/jtreg/runtime/appcds/jigsaw/classpathtests/EmptyClassInBootClassPath.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
* 2) app loader will load the class from the jimage by default;
3030
* app loader will load the class from the bootclasspath if the
3131
* "--limit-modules java.base" option is specified
32-
* @requires (vm.opt.UseCompressedOops == null) | (vm.opt.UseCompressedOops == true)
32+
* @requires ((vm.opt.UseCompressedOops == null) | (vm.opt.UseCompressedOops == true)) & !vm.graal.enabled
3333
* @library /test/lib /test/hotspot/jtreg/runtime/appcds
3434
* @modules java.base/jdk.internal.misc
3535
* java.management

test/hotspot/jtreg/runtime/appcds/jigsaw/limitmods/LimitModsTests.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424

2525
/**
2626
* @test
27-
* @requires (vm.opt.UseCompressedOops == null) | (vm.opt.UseCompressedOops == true)
27+
* @requires ((vm.opt.UseCompressedOops == null) | (vm.opt.UseCompressedOops == true)) & !vm.graal.enabled
2828
* @library ../..
2929
* @library /test/lib
3030
* @modules java.base/jdk.internal.misc

test/jdk/TEST.ROOT

+1
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ requires.extraPropDefns.vmOpts = -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI
3636
requires.properties= \
3737
sun.arch.data.model \
3838
java.runtime.name \
39+
vm.graal.enabled \
3940
vm.cds
4041

4142
# Minimum jtreg version

test/jdk/com/sun/tools/attach/modules/Driver.java

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323

2424
/**
2525
* @test
26+
* @requires !vm.graal.enabled
2627
* @modules jdk.attach
2728
* @build m/* Agent
2829
* @run main/othervm -Djdk.attach.allowAttachSelf m/p.Main jmx javaagent

test/jdk/java/lang/String/concat/WithSecurityManager.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2016, 2017, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -27,6 +27,7 @@
2727
* @test
2828
* @summary String concatenation fails with a custom SecurityManager that uses concatenation
2929
* @bug 8155090 8158851
30+
* @requires !vm.graal.enabled
3031
*
3132
* @compile WithSecurityManager.java
3233
*

test/jdk/java/lang/System/LoggerFinder/LoggerFinderAPI/LoggerFinderAPI.java

+1
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@
4646
* throwing NullPointerException. The test uses --limit-module
4747
* to force the selection of one or the other.
4848
* @author danielfuchs
49+
* @requires !vm.graal.enabled
4950
* @build LoggerFinderAPI
5051
* @run main/othervm --limit-modules java.base,java.logging
5152
* -Djava.util.logging.SimpleFormatter.format=LOG-%4$s:-[%2$s]-%5$s%6$s%n

test/jdk/java/lang/instrument/TestAgentWithLimitMods.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2016, 2017, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -24,6 +24,7 @@
2424
/**
2525
*
2626
* @test
27+
* @requires !vm.graal.enabled
2728
* @summary Tests that the -javaagent option adds the java.instrument into
2829
* the module graph
2930
*

test/jdk/java/lang/management/ManagementFactory/DefaultManagementProviderTest.java

+1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
* @bug 8151099
2727
* @summary Verify platform MXBeans initialized properly with java.management
2828
* module only. No other management provider
29+
* @requires !vm.graal.enabled
2930
* @modules java.management
3031
* @run main/othervm --limit-modules=java.management DefaultManagementProviderTest
3132
*/

test/jdk/java/net/SocketOption/OptionsTest.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2014, 2016, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2014, 2017, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -24,6 +24,7 @@
2424
/*
2525
* @test
2626
* @bug 8036979 8072384 8044773
27+
* @requires !vm.graal.enabled
2728
* @run main/othervm -Xcheck:jni OptionsTest
2829
* @run main/othervm -Xcheck:jni -Djava.net.preferIPv4Stack=true OptionsTest
2930
* @run main/othervm --limit-modules=java.base OptionsTest

test/jdk/java/net/SocketOption/UnsupportedOptionsTest.java

+1
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
* @bug 8143554 8044773
3333
* @summary Test checks that UnsupportedOperationException for unsupported
3434
* SOCKET_OPTIONS is thrown by both getOption() and setOption() methods.
35+
* @requires !vm.graal.enabled
3536
* @run main UnsupportedOptionsTest
3637
* @run main/othervm --limit-modules=java.base UnsupportedOptionsTest
3738
*/

test/jdk/java/nio/channels/DatagramChannel/SocketOptionTests.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2007, 2016, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2007, 2017, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -24,6 +24,7 @@
2424
/* @test
2525
* @bug 4640544 8044773
2626
* @summary Unit test for setOption/getOption/options methods
27+
* @requires !vm.graal.enabled
2728
* @run main SocketOptionTests
2829
* @run main/othervm --limit-modules=java.base SocketOptionTests
2930
*/

test/jdk/java/nio/channels/ServerSocketChannel/SocketOptionTests.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2007, 2016, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2007, 2017, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -25,6 +25,7 @@
2525
* @bug 4640544 8044773
2626
* @summary Unit test for ServerSocketChannel setOption/getOption/options
2727
* methods.
28+
* @requires !vm.graal.enabled
2829
* @run main SocketOptionTests
2930
* @run main/othervm --limit-modules=java.base SocketOptionTests
3031
*/

test/jdk/java/nio/channels/SocketChannel/SocketOptionTests.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (c) 2007, 2011, Oracle and/or its affiliates. All rights reserved.
2+
* Copyright (c) 2007, 2017, Oracle and/or its affiliates. All rights reserved.
33
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
44
*
55
* This code is free software; you can redistribute it and/or modify it
@@ -25,6 +25,7 @@
2525
* @bug 4640544 8044773
2626
* @summary Unit test to check SocketChannel setOption/getOption/options
2727
* methods.
28+
* @requires !vm.graal.enabled
2829
* @run main SocketOptionTests
2930
* @run main/othervm --limit-modules=java.base SocketOptionTests
3031
*/

test/jdk/tools/launcher/modules/limitmods/LimitModsTest.java

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323

2424
/**
2525
* @test
26+
* @requires !vm.graal.enabled
2627
* @library /lib/testlibrary /test/lib
2728
* @modules java.desktop java.logging jdk.compiler
2829
* @build LimitModsTest jdk.test.lib.compiler.CompilerUtils jdk.testlibrary.*

test/jdk/tools/launcher/modules/listmods/ListModsTest.java

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323

2424
/**
2525
* @test
26+
* @requires !vm.graal.enabled
2627
* @library /lib/testlibrary /test/lib
2728
* @modules java.se
2829
* @build ListModsTest jdk.test.lib.compiler.CompilerUtils jdk.testlibrary.*

test/jdk/tools/launcher/modules/showmoduleresolution/ShowModuleResolutionTest.java

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323

2424
/**
2525
* @test
26+
* @requires !vm.graal.enabled
2627
* @modules jdk.jdeps jdk.zipfs
2728
* @library /lib/testlibrary
2829
* @build ShowModuleResolutionTest jdk.testlibrary.*

0 commit comments

Comments
 (0)