ALSA: ak4117: remove redundant check on err being < 0

Colin Ian King · tiwai · commit 3805e6a18d45 · 2016-07-12T12:26:09.000+02:00
snd_ak4117_create checks if the error return err is less than zero
or not.  This is a redundant check, err can only be &lt; 0 to get to
the __fail label, in which case just return err and remove the
redundant check (since we never return -EIO).

Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Signed-off-by: Takashi Iwai &lt;tiwai@suse.de&gt;
diff --git a/sound/i2c/other/ak4117.c b/sound/i2c/other/ak4117.c
@@ -110,7 +110,7 @@ int snd_ak4117_create(struct snd_card *card, ak4117_read_t *read, ak4117_write_t
 
       __fail:
 	snd_ak4117_free(chip);
-	return err < 0 ? err : -EIO;
+	return err;
 }
 
 void snd_ak4117_reg_write(struct ak4117 *chip, unsigned char reg, unsigned char mask, unsigned char val)

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ int snd_ak4117_create(struct snd_card card, ak4117_read_t read, ak4117_write_t`
`110`	`110`
`111`	`111`	`__fail:`
`112`	`112`	`snd_ak4117_free(chip);`
`113`		`- return err < 0 ? err : -EIO;`
	`113`	`+ return err;`
`114`	`114`	`}`
`115`	`115`
`116`	`116`	`void snd_ak4117_reg_write(struct ak4117 *chip, unsigned char reg, unsigned char mask, unsigned char val)`