ALSA: cs5530: Fix resource leak in error path

tiwai · tiwai · commit 5a798394c85f · 2012-08-30T13:21:00.000-07:00
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=44741 Signed-off-by: Takashi Iwai <tiwai@suse.de>
diff --git a/sound/pci/cs5530.c b/sound/pci/cs5530.c
@@ -142,8 +142,7 @@ static int __devinit snd_cs5530_create(struct snd_card *card,
 
 	mem = pci_ioremap_bar(pci, 0);
 	if (mem == NULL) {
-		kfree(chip);
-		pci_disable_device(pci);
+		snd_cs5530_free(chip);
 		return -EBUSY;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -142,8 +142,7 @@ static int __devinit snd_cs5530_create(struct snd_card *card,`
`142`	`142`
`143`	`143`	`mem = pci_ioremap_bar(pci, 0);`
`144`	`144`	`if (mem == NULL) {`
`145`		`- kfree(chip);`
`146`		`- pci_disable_device(pci);`
	`145`	`+ snd_cs5530_free(chip);`
`147`	`146`	`return -EBUSY;`
`148`	`147`	`}`
`149`	`148`