Skip to content

Commit 88abd82

Browse files
committed
Merge branch 'for-4.9-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata
Pull libata fixes from Tejun Heo: "The recent changes in ahci MSI handling need one more fix. Hopefully, this restores parity with before. The other two are minor fixes with both low impact and risk" * 'for-4.9-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata: ahci: always fall back to single-MSI mode libata-scsi: Fixup ata_gen_passthru_sense() mvsas: fix error return code in mvs_task_prep()
2 parents 96e52d3 + 6929ef3 commit 88abd82

File tree

3 files changed

+4
-9
lines changed

3 files changed

+4
-9
lines changed

drivers/ata/ahci.c

-7
Original file line numberDiff line numberDiff line change
@@ -1436,13 +1436,6 @@ static int ahci_init_msi(struct pci_dev *pdev, unsigned int n_ports,
14361436
"ahci: MRSM is on, fallback to single MSI\n");
14371437
pci_free_irq_vectors(pdev);
14381438
}
1439-
1440-
/*
1441-
* -ENOSPC indicated we don't have enough vectors. Don't bother
1442-
* trying a single vectors for any other error:
1443-
*/
1444-
if (nvec < 0 && nvec != -ENOSPC)
1445-
return nvec;
14461439
}
14471440

14481441
/*

drivers/ata/libata-scsi.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -1088,7 +1088,7 @@ static void ata_gen_passthru_sense(struct ata_queued_cmd *qc)
10881088
desc[1] = tf->command; /* status */
10891089
desc[2] = tf->device;
10901090
desc[3] = tf->nsect;
1091-
desc[0] = 0;
1091+
desc[7] = 0;
10921092
if (tf->flags & ATA_TFLAG_LBA48) {
10931093
desc[8] |= 0x80;
10941094
if (tf->hob_nsect)

drivers/scsi/mvsas/mv_sas.c

+3-1
Original file line numberDiff line numberDiff line change
@@ -791,8 +791,10 @@ static int mvs_task_prep(struct sas_task *task, struct mvs_info *mvi, int is_tmf
791791
slot->slot_tag = tag;
792792

793793
slot->buf = pci_pool_alloc(mvi->dma_pool, GFP_ATOMIC, &slot->buf_dma);
794-
if (!slot->buf)
794+
if (!slot->buf) {
795+
rc = -ENOMEM;
795796
goto err_out_tag;
797+
}
796798
memset(slot->buf, 0, MVS_SLOT_BUF_SZ);
797799

798800
tei.task = task;

0 commit comments

Comments
 (0)