Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing people from Events #1

Open
sgreenslade opened this issue Jan 5, 2017 · 2 comments
Open

Removing people from Events #1

sgreenslade opened this issue Jan 5, 2017 · 2 comments

Comments

@sgreenslade
Copy link
Contributor

Hi,

Version: 2.6.2 - GitHub Master

I've found a couple of issues when removing people from Events. Here is what I did:

  • Create an Event and add people.
  • Go Back to the home page and click the arrow to expand the event.
  • By the person, click the X icon.
    Issue 1) The pop-down yes / cancel dialog could do with some CSS
  • If I click YesThe person is removed from the event (via the removeEventPeople() function)
  • The person no-longer appears connected with the event.
  • If I then click the 'spanner' edit icon by the event (createEvent.php) and scroll down,the person is still ticked.
  • To add then, I need to un-tic, update,edit, tick and update.

Either the removeEventPeople() function needs to be changed to delete the record OR The createEvent.php page needs to take into account the deleted flag.
I don't know the history so am not sure which direction you are heading.

Thanks

Steve

@Little-Ben
Copy link
Owner

I can reproduce both problems. I am planning to look for that tomorrow (Friday). The whole process of checkboxes and deleting is by former developer David, so I need to think through it. Maybe the deleted flag was introduced by me, I am not sure anymore.

Might be the easiest to reduce to one functionality, i.e. only via createEvent (because in most cases when you delete one person, you want to add another one right away - therefore you need to go there anyways).

@sgreenslade
Copy link
Contributor Author

Hi Ben,

Thanks. What ever you think is best.
Personally I quite like the ability to quickly remove users from an event, without going to the createEvent page.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants