Skip to content

Commit ba29d8b

Browse files
author
Daniel Jaeckle
committed
Remove examples class A, B and C. Replace with periodic-uplink example.
1 parent f76bdca commit ba29d8b

File tree

33 files changed

+34
-36613
lines changed

33 files changed

+34
-36613
lines changed

.vscode/settings.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
"APPLICATION":"LoRaMac",
2828

2929
// Select LoRaMac sub project. You can choose between:
30-
// classA, classB or classC, periodic-uplink-lpp, fuota-test-01.
30+
// periodic-uplink-lpp, fuota-test-01.
3131
"SUB_PROJECT":"periodic-uplink-lpp",
3232

3333
// Switch for Class B support of LoRaMac:

CHANGELOG.md

+6-2
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,12 @@ Please refer to [Releases pre-certification-results](https://github.com/Lora-net
1313

1414
### General
1515

16-
- Release based on "LoRaWAN specification 1.0.3" and "LoRaWAN Regional Parameters v1.0.3revA"
17-
- GitHub reported issues corrections. Please refer to [Release Version 4.4.4](https://github.com/Lora-net/LoRaMac-node/milestone/6)
16+
- Release based on "LoRaWAN specification 1.0.4"/"LoRaWAN specification 1.1.1" and "LoRaWAN Regional Parameters 2-1.0.1"
17+
- GitHub reported issues corrections. Please refer to [Release Version 5.0.0](https://github.com/Lora-net/LoRaMac-node/milestone/3)
18+
19+
### Removed
20+
21+
- Removed ClassA, ClassB and ClassC examples.
1822

1923
### Fixed
2024

README.md

+2-8
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,6 @@ This project fully implements ClassA, ClassB and ClassC end-device classes and i
2929

3030
For each currently supported platform example applications are provided.
3131

32-
* **LoRaMac/classA**: ClassA end-device example application.
33-
34-
* **LoRaMac/classB**: ClassB end-device example application.
35-
36-
* **LoRaMac/classC**: ClassC end-device example application.
37-
3832
* **LoRaMac/fuota-test-01**: FUOTA test scenario 01 end-device example application. (Based on provided application common packages)
3933

4034
* **LoRaMac/periodic-uplink-lpp**: ClassA/B/C end-device example application. Periodically uplinks a frame using the Cayenne LPP protocol. (Based on provided application common packages)
@@ -223,7 +217,7 @@ $ make
223217
"APPLICATION":"LoRaMac",
224218

225219
// Select LoRaMac sub project. You can choose between:
226-
// classA, classB or classC, periodic-uplink-lpp, fuota-test-01.
220+
// periodic-uplink-lpp, fuota-test-01.
227221
"SUB_PROJECT":"periodic-uplink-lpp",
228222

229223
// Switch for Class B support of LoRaMac:
@@ -324,7 +318,7 @@ $ make
324318
"APPLICATION":"ping-pong",
325319

326320
// Select LoRaMac sub project. You can choose between:
327-
// classA, classB or classC, periodic-uplink-lpp, fuota-test-01.
321+
// periodic-uplink-lpp, fuota-test-01.
328322
"SUB_PROJECT":"periodic-uplink-lpp",
329323

330324
// Switch for Class B support of LoRaMac:

doc/development-environment.md

+1-4
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ For Windows platforms the prefix has to be provided anyway and additionally the
6969
The possibility to choose the application, target board and more options can be done using the provided configuration options.
7070

7171
These configuration options can be set through additional commandline parameters, for example:
72-
`cmake -DCMAKE_TOOLCHAIN_FILE="cmake/toolchain-arm-none-eabi.cmake" -DAPPLICATION="LoRaMac" -DSUB_PROJECT="classC" ..`
72+
`cmake -DCMAKE_TOOLCHAIN_FILE="cmake/toolchain-arm-none-eabi.cmake" -DAPPLICATION="LoRaMac" -DSUB_PROJECT="periodic-uplink-lpp" ..`
7373

7474
Alternatively one can use a graphical interface to configure CMake, drop down menus and check boxes will provide to the user the possible options.
7575

@@ -87,9 +87,6 @@ Alternatively one can use a graphical interface to configure CMake, drop down me
8787
* `SUB_PROJECT` - LoRaMac sub project example choice.
8888
**Note**: Only applicable to LoRaMac `APPLICATION` choice.
8989
The possible choices are:
90-
* classA
91-
* classB
92-
* classC
9390
* periodic-uplink-lpp
9491
* fuota-test-01
9592
* `ACTIVE_REGION` - Active region for which the stack will be initialized.

src/apps/LoRaMac/CMakeLists.txt

+6-25
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ cmake_minimum_required(VERSION 3.6)
2323
#---------------------------------------------------------------------------------------
2424

2525
# Allow switching of sub projects
26-
set(SUB_PROJECT_LIST classA classB classC periodic-uplink-lpp fuota-test-01)
27-
set(SUB_PROJECT classA CACHE STRING "Default sub project is Class A")
26+
set(SUB_PROJECT_LIST periodic-uplink-lpp fuota-test-01)
27+
set(SUB_PROJECT periodic-uplink-lpp CACHE STRING "Default sub project is periodic-uplink-lpp")
2828
set_property(CACHE SUB_PROJECT PROPERTY STRINGS ${SUB_PROJECT_LIST})
2929

3030
# Allow switching of active region
@@ -35,8 +35,8 @@ set(ACTIVE_REGION_LIST LORAMAC_REGION_EU868 LORAMAC_REGION_US915 LORAMAC_REGIO
3535
set(ACTIVE_REGION LORAMAC_REGION_EU868 CACHE STRING "Default active region is EU868")
3636
set_property(CACHE ACTIVE_REGION PROPERTY STRINGS ${ACTIVE_REGION_LIST})
3737

38-
if((SUB_PROJECT STREQUAL classB OR SUB_PROJECT STREQUAL periodic-uplink-lpp OR SUB_PROJECT STREQUAL fuota-test-01) AND NOT CLASSB_ENABLED )
39-
message(FATAL_ERROR "Please turn on Class B support of LoRaMac ( CLASSB_ENABLED=ON ) to use Class B, periodic-uplink-lpp, fuota-test-01 sub projects")
38+
if((SUB_PROJECT STREQUAL periodic-uplink-lpp OR SUB_PROJECT STREQUAL fuota-test-01) AND NOT CLASSB_ENABLED )
39+
message(FATAL_ERROR "Please turn on Class B support of LoRaMac ( CLASSB_ENABLED=ON ) to use periodic-uplink-lpp, fuota-test-01 sub projects")
4040
endif()
4141

4242
# Allow selection of secure-element provisioning method
@@ -99,27 +99,8 @@ elseif(SUB_PROJECT STREQUAL fuota-test-01)
9999
"${CMAKE_CURRENT_LIST_DIR}/common/LmHandler/packages/LmhpRemoteMcastSetup.c"
100100
)
101101

102-
else() #if(SUB_PROJECT STREQUAL classA OR SUB_PROJECT STREQUAL classB OR SUB_PROJECT STREQUAL classC)
103-
104-
#---------------------------------------------------------------------------------------
105-
# Application common features handling
106-
#---------------------------------------------------------------------------------------
107-
list(APPEND ${PROJECT_NAME}_COMMON
108-
"${CMAKE_CURRENT_LIST_DIR}/common/NvmCtxMgmt.c"
109-
)
110-
111-
#---------------------------------------------------------------------------------------
112-
# Application LoRaMac handler
113-
#---------------------------------------------------------------------------------------
114-
list(APPEND ${PROJECT_NAME}_LMH
115-
)
116-
117-
#---------------------------------------------------------------------------------------
118-
# LoRaMac handler applicative packages
119-
#---------------------------------------------------------------------------------------
120-
list(APPEND ${PROJECT_NAME}_LMHP
121-
)
122-
102+
else()
103+
message(FATAL_ERROR "Unknown SUB_PROJECT")
123104
endif()
124105

125106
#---------------------------------------------------------------------------------------

0 commit comments

Comments
 (0)