config: introduce feedback options

This patch introduces all feedback options.

Part of tarantool#8861

NO_DOC=Was already described before.

Author: ImeevMA

changelogs/unreleased/gh-8861-feedback-options.md

@@ -0,0 +1,3 @@
+## feature/config
+
+* All feedback options are now supported (gh-8861).

src/box/lua/config/instance_config.lua

@@ -232,6 +232,17 @@ local function advertise_peer_uri_validate(data, w)
     return uri
 end
 
+local function feedback_apply_default_if(_data, _w)
+    return box.internal.feedback_daemon ~= nil
+end
+
+local function feedback_validate(data, w)
+    if data == nil or box.internal.feedback_daemon ~= nil then
+        return
+    end
+    w.error('Tarantool is built without feedback reports sending support')
+end
+
 return schema.new('instance_config', schema.record({
     config = schema.record({
         version = schema.enum({
@@ -1179,6 +1190,57 @@ return schema.new('instance_config', schema.record({
             end
         end,
     }),
+    feedback = schema.record({
+        enabled = schema.scalar({
+            type = 'boolean',
+            box_cfg = 'feedback_enabled',
+            default = true,
+            apply_default_if = feedback_apply_default_if,
+            validate = feedback_validate,
+        }),
+        crashinfo = schema.scalar({
+            type = 'boolean',
+            box_cfg = 'feedback_crashinfo',
+            default = true,
+            apply_default_if = feedback_apply_default_if,
+            validate = feedback_validate,
+        }),
+        host = schema.scalar({
+            type = 'string',
+            box_cfg = 'feedback_host',
+            default = 'https://feedback.tarantool.io',
+            apply_default_if = feedback_apply_default_if,
+            validate = feedback_validate,
+        }),
+        metrics_collect_interval = schema.scalar({
+            type = 'number',
+            box_cfg = 'feedback_metrics_collect_interval',
+            default = 60,
+            apply_default_if = feedback_apply_default_if,
+            validate = feedback_validate,
+        }),
+        send_metrics = schema.scalar({
+            type = 'boolean',
+            box_cfg = 'feedback_send_metrics',
+            default = true,
+            apply_default_if = feedback_apply_default_if,
+            validate = feedback_validate,
+        }),
+        interval = schema.scalar({
+            type = 'number',
+            box_cfg = 'feedback_interval',
+            default = 3600,
+            apply_default_if = feedback_apply_default_if,
+            validate = feedback_validate,
+        }),
+        metrics_limit = schema.scalar({
+            type = 'integer',
+            box_cfg = 'feedback_metrics_limit',
+            default = 1024 * 1024,
+            apply_default_if = feedback_apply_default_if,
+            validate = feedback_validate,
+        }),
+    }),
 }, {
     -- This kind of validation cannot be implemented as the
     -- 'validate' annotation of a particular schema node. There

test/config-luatest/cluster_config_schema_test.lua

@@ -222,6 +222,15 @@ g.test_defaults = function()
         config = {
             reload = 'auto',
         },
+        feedback = box.internal.feedback_daemon ~= nil and {
+            crashinfo = true,
+            host = 'https://feedback.tarantool.io',
+            metrics_collect_interval = 60,
+            send_metrics = true,
+            enabled = true,
+            interval = 3600,
+            metrics_limit = 1024*1024,
+        } or nil,
     }
     local res = cluster_config:apply_default({})
     t.assert_equals(res, exp)

test/config-luatest/config_test.lua

@@ -343,3 +343,51 @@ g.test_remaining_vinyl_options = function()
         t.assert_equals(box.cfg.vinyl_timeout, 7.5)
     end)
 end
+
+g.test_feedback_options = function()
+    t.skip_if(box.internal.feedback_daemon == nil, 'Feedback is disabled')
+    local dir = treegen.prepare_directory(g, {}, {})
+    local config = [[
+        credentials:
+          users:
+            guest:
+              roles:
+              - super
+
+        iproto:
+          listen: unix/:./{{ instance_name }}.iproto
+
+        feedback:
+          crashinfo: false
+          host: 'https://feedback.tarantool.io'
+          metrics_collect_interval: 120
+          send_metrics: false
+          enabled: false
+          interval: 7200
+          metrics_limit: 1000000
+
+        groups:
+          group-001:
+            replicasets:
+              replicaset-001:
+                instances:
+                  instance-001: {}
+    ]]
+    local config_file = treegen.write_script(dir, 'config.yaml', config)
+    local opts = {
+        config_file = config_file,
+        alias = 'instance-001',
+        chdir = dir,
+    }
+    g.server = server:new(opts)
+    g.server:start()
+    g.server:exec(function()
+        t.assert_equals(box.cfg.feedback_crashinfo, false)
+        t.assert_equals(box.cfg.feedback_host, 'https://feedback.tarantool.io')
+        t.assert_equals(box.cfg.feedback_metrics_collect_interval, 120)
+        t.assert_equals(box.cfg.feedback_send_metrics, false)
+        t.assert_equals(box.cfg.feedback_enabled, false)
+        t.assert_equals(box.cfg.feedback_interval, 7200)
+        t.assert_equals(box.cfg.feedback_metrics_limit, 1000000)
+    end)
+end

test/config-luatest/instance_config_schema_test.lua

@@ -1044,15 +1044,6 @@ g.test_box_cfg_coverage = function()
         password_enforce_specialchars = true,
         password_history_length = true,
 
-        -- TODO: Will be added in the scope of gh-8861.
-        feedback_enabled = true,
-        feedback_crashinfo = true,
-        feedback_host = true,
-        feedback_interval = true,
-        feedback_send_metrics = true,
-        feedback_metrics_collect_interval = true,
-        feedback_metrics_limit = true,
-
         -- TODO: Will be added in the scope of gh-8861.
         flightrec_enabled = true,
         flightrec_logs_size = true,
@@ -1095,11 +1086,18 @@ g.test_box_cfg_coverage = function()
 
     -- Collect box_cfg annotations from the schema.
     local box_cfg_options_in_schema = instance_config:pairs():filter(function(w)
+        if w.schema.box_cfg == nil then
+            return false
+        end
         -- Skip EE options on CE.
         if w.schema.enterprise_edition and not is_enterprise then
             return false
         end
-        return w.schema.box_cfg ~= nil
+        -- Skip feedback options if feedback is disabled.
+        if w.schema.box_cfg:startswith('feedback') then
+            return box.internal.feedback_daemon ~= nil
+        end
+        return true
     end):map(function(w)
         return w.schema.box_cfg, {
             path = table.concat(w.path, '.'),
@@ -1169,3 +1167,46 @@ g.test_box_cfg_coverage = function()
         end
     end
 end
+
+g.test_feedback_enabled = function()
+    t.skip_if(box.internal.feedback_daemon == nil, 'Feedback is disabled')
+    local iconfig = {
+        feedback = {
+            crashinfo = false,
+            host = 'one',
+            metrics_collect_interval = 1,
+            send_metrics = false,
+            enabled = true,
+            interval = 2,
+            metrics_limit = 3,
+        },
+    }
+    instance_config:validate(iconfig)
+    validate_fields(iconfig.feedback, instance_config.schema.fields.feedback)
+
+    local exp = {
+        crashinfo = true,
+        host = 'https://feedback.tarantool.io',
+        metrics_collect_interval = 60,
+        send_metrics = true,
+        enabled = true,
+        interval = 3600,
+        metrics_limit = 1024*1024,
+    }
+    local res = instance_config:apply_default({}).feedback
+    t.assert_equals(res, exp)
+end
+
+g.test_feedback_disabled = function()
+    t.skip_if(box.internal.feedback_daemon ~= nil, 'Feedback is enabled')
+    local iconfig = {
+        feedback = {
+            enabled = true,
+        },
+    }
+    local ok, err = pcall(instance_config.validate, instance_config, iconfig)
+    t.assert(not ok)
+    local exp = '[instance_config] feedback.enabled: Tarantool is built '..
+                'without feedback reports sending support'
+    t.assert_equals(err, exp)
+end