Merge pull request #107 from LuCEresearchlab/keyboard-binding-changes

malags · web-flow · commit e5fa413452ff · 2021-05-06T16:04:11.000+02:00
Changed binding for info button
diff --git a/frontend/src/components/tagger_component/MisconceptionInfoButton.tsx b/frontend/src/components/tagger_component/MisconceptionInfoButton.tsx
@@ -47,7 +47,7 @@ function MisconceptionInfoButton({tags, handled_element, keyboardIndex}: Input)
     // end popup stuff
 
     withKeyboard((command => {
-        if (keyboardIndex != undefined && (command == '' + keyboardIndex + 'h')) {
+        if (keyboardIndex != undefined && (command == '' + keyboardIndex + '?')) {
             ref.current?.click()
         }
     }))
diff --git a/frontend/src/hooks/withKeyboard.ts b/frontend/src/hooks/withKeyboard.ts
@@ -40,7 +40,7 @@ function withKeyboard(action: (command: string) => void) {
                     setCommand(command.substring(0, command.length - 1))
                 } else if (key.length == 1 && allowedInputs.test(key)) {
                     setCommand(command + key)
-                } else setCommand('')
+                }
             }
 
             document.addEventListener('keydown', func)

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ function MisconceptionInfoButton({tags, handled_element, keyboardIndex}: Input)`
`47`	`47`	`// end popup stuff`
`48`	`48`
`49`	`49`	`withKeyboard((command => {`
`50`		`- if (keyboardIndex != undefined && (command == '' + keyboardIndex + 'h')) {`
	`50`	`+ if (keyboardIndex != undefined && (command == '' + keyboardIndex + '?')) {`
`51`	`51`	`ref.current?.click()`
`52`	`52`	`}`
`53`	`53`	`}))`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ function withKeyboard(action: (command: string) => void) {`
`40`	`40`	`setCommand(command.substring(0, command.length - 1))`
`41`	`41`	`} else if (key.length == 1 && allowedInputs.test(key)) {`
`42`	`42`	`setCommand(command + key)`
`43`		`- } else setCommand('')`
	`43`	`+ }`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`document.addEventListener('keydown', func)`