no need to throw to report errors

Author: lbargaoanu

docs/source/Configuration-validation.md

@@ -55,4 +55,4 @@ To skip validation altogether for this map, use `MemberList.None`. That's the de
 
 ## Custom validations
 
-You can add custom validations through an extension point. See [here](https://github.com/AutoMapper/AutoMapper/blob/bdc0120497d192a2741183415543f6119f50a982/src/UnitTests/CustomValidations.cs#L42).
+You can add custom validations through an extension point. See [here](https://github.com/AutoMapper/AutoMapper/blob/master/src/UnitTests/CustomValidations.cs).

src/UnitTests/ConfigurationValidation.cs

@@ -5,16 +5,12 @@ public class Source
     {
         public decimal Foo { get; set; }
     }
-
     public class Destination
     {
         public Type Foo { get; set; }
         public string Bar { get; set; }
     }
-
-    protected override MapperConfiguration CreateConfiguration() =>
-        new(cfg => { cfg.CreateMap<Source, Destination>(); });
-
+    protected override MapperConfiguration CreateConfiguration() => new(cfg => cfg.CreateMap<Source, Destination>());
     [Fact]
     public void Should_throw_unmapped_member_and_mismatched_type_exceptions()
     {
@@ -35,24 +31,19 @@ public void Should_throw_unmapped_member_and_mismatched_type_exceptions()
             );
     }
 }
-
 public class When_testing_a_dto_with_mismatches_in_multiple_children : AutoMapperSpecBase
 {
     public class Source
     {
         public Type Foo { get; set; }
         public Type Bar { get; set; }
     }
-
     public class Destination
     {
         public int Foo { get; set; }
         public int Bar { get; set; }
     }
-
-    protected override MapperConfiguration CreateConfiguration() =>
-        new(cfg => { cfg.CreateMap<Source, Destination>(); });
-
+    protected override MapperConfiguration CreateConfiguration() => new(cfg => cfg.CreateMap<Source, Destination>());
     [Fact]
     public void Should_throw_for_both_mismatched_children()
     {
@@ -101,7 +92,7 @@ private ComplexType(int someMember)
     });
 
     [Fact]
-    public void Should_fail_validation() => new Action(AssertConfigurationIsValid).ShouldThrowException<AutoMapperConfigurationException>(ex=>
+    public void Should_fail_validation() => new Action(AssertConfigurationIsValid).ShouldThrowException<AutoMapperConfigurationException>(ex =>
         ex.MemberMap.ToString().ShouldBe("Void .ctor(ComplexType), parameter myComplexMember"));
 }
 
@@ -204,7 +195,7 @@ public Dest(int value)
         public int Value { get; }
     }
 
-    protected override MapperConfiguration CreateConfiguration() => new(cfg => cfg.CreateMap<Source, Dest>().ForCtorParam("value", o=>o.MapFrom(s=>4)));
+    protected override MapperConfiguration CreateConfiguration() => new(cfg => cfg.CreateMap<Source, Dest>().ForCtorParam("value", o => o.MapFrom(s => 4)));
 
     [Fact]
     public void Should_map() => Mapper.Map<Dest>(new Source()).Value.ShouldBe(4);
@@ -384,7 +375,7 @@ class ValueConverter : IValueConverter<int, int>
     {
         cfg.CreateMap<Source, Destination>(MemberList.Source)
             .ForMember(d => d.ResolvedDest, o => o.MapFrom<MemberResolver, int>("Resolved"))
-            .ForMember(d=>d.TypedResolvedDest, o => o.MapFrom<MemberResolver, int>(s => s.TypedResolved))
+            .ForMember(d => d.TypedResolvedDest, o => o.MapFrom<MemberResolver, int>(s => s.TypedResolved))
             .ForMember(d => d.ConvertedDest, o => o.ConvertUsing<ValueConverter, int>("Converted"))
             .ForMember(d => d.TypedConvertedDest, o => o.ConvertUsing<ValueConverter, int>(s => s.TypedConverted));
     });
@@ -409,8 +400,8 @@ class Destination
     {
         public string OtherValue { get; set; }
     }
-    protected override MapperConfiguration CreateConfiguration() => new(c=>c.CreateMap<Source, Destination>(MemberList.Source)
-        .ForMember(d=>d.OtherValue, o=>o.MapFrom(s=>s.Value ?? "")));
+    protected override MapperConfiguration CreateConfiguration() => new(c => c.CreateMap<Source, Destination>(MemberList.Source)
+        .ForMember(d => d.OtherValue, o => o.MapFrom(s => s.Value ?? "")));
     [Fact]
     public void Should_be_ignored() => new Action(AssertConfigurationIsValid)
         .ShouldThrow<AutoMapperConfigurationException>().Errors[0].UnmappedPropertyNames[0].ShouldBe(nameof(Source.Value));
@@ -515,10 +506,10 @@ public class OtherDest
     protected override void Because_of()
     {
         try
-        {
-           AssertConfigurationIsValid();
+        {
+            AssertConfigurationIsValid();
         }
-        catch (AutoMapperConfigurationException ex)
+        catch(AutoMapperConfigurationException ex)
         {
             _exception = ex;
         }
@@ -559,7 +550,7 @@ protected override void Because_of()
         {
             AssertConfigurationIsValid();
         }
-        catch (AutoMapperConfigurationException ex)
+        catch(AutoMapperConfigurationException ex)
         {
             _exception = ex;
         }

src/UnitTests/CustomValidations.cs

@@ -38,7 +38,7 @@ public void Should_call_the_validator()
                 cfg.CreateMap<Source, Dest>();
             });
 
-            config.AssertConfigurationIsValid();
+            new Action(config.AssertConfigurationIsValid).ShouldThrow<AutoMapperConfigurationException>().Message.ShouldBe(nameof(When_using_custom_validation));
 
             _calledForRoot.ShouldBeTrue();
             _calledForValues.ShouldBeTrue();
@@ -55,6 +55,7 @@ private void Validator(ValidationContext context)
                 context.Types.DestinationType.ShouldBe(typeof(Dest));
                 context.ObjectMapper.ShouldBeNull();
                 context.MemberMap.ShouldBeNull();
+                context.Exceptions.Add(new AutoMapperConfigurationException(nameof(When_using_custom_validation)));
             }
             else
             {