Any main map configuration overrides IncludeMembers configuration for a given member

[sergii-van]

When using IncludeMembers and ForAllMembers with Condition/Precondition, the condition code is not being called.

Source/destination types

    public class WrapperEntity
    {
        private readonly BusinessEntity instance = new BusinessEntity { Id = 1, Name = "1" };

        public BusinessEntity GetInstance()
        {
            return this.instance;
        }

        public bool ShouldMap(string propertyName)
        {
            return "Name".Equals(propertyName, StringComparison.OrdinalIgnoreCase);
        }
    }

    public class WrapperEntityNoPreconditions
    {
        private readonly BusinessEntity instance = new BusinessEntity { Id = 4, Name = "4" };

        public BusinessEntity GetInstance()
        {
            return this.instance;
        }
    }

    public class BusinessEntity
    {
        public int Id { get; set; }

        public string Name { get; set; } = null!;
    }

    public class DatabaseEntity
    {
        public int Id { get; set; }

        public string Name { get; set; } = null!;
    }

Mapping configuration

            this.CreateMap<BusinessEntity, DatabaseEntity>().ReverseMap();

            // works as expected
            this.CreateMap<WrapperEntityNoPreconditions, DatabaseEntity>().IncludeMembers(x => x.GetInstance());

            // Condition is not being called, unless ".ForMember" is specified
            this.CreateMap<WrapperEntity, DatabaseEntity>()
                .IncludeMembers(x => x.GetInstance())
                .ForAllMembers(x => x.Condition((source, destination, resolutionContext) =>
                {
                    return source.ShouldMap(x.DestinationMember.Name);
                }));

Version: 10.1.1

Expected behavior

IncludeMembers and ForAllMembers with Condition/Precondition should work together. For each property/member from instance + added members from IncludeMembers conditional mapping should be called.

Actual behavior

When specifying both IncludeMembers and ForAllMembers Condition/Precondition code is not being called.

Steps to reproduce

        [TestMethod]
        public void Map_Should_Convert_Wrapped_Entity_Successfully()
        {
            this.mapper = new MapperConfiguration(cfg => cfg.AddProfile<AutoMapperProfile>()).CreateMapper();

            var businessEntity = new BusinessEntity { Id = 2, Name = "2"};
            DatabaseEntity mappedDb = this.mapper.Map<DatabaseEntity>(businessEntity);

            // mappedDb id == 2; name == "2" as expected
            mappedDb.Should().BeEquivalentTo(businessEntity);

            var databaseEntity = new DatabaseEntity {Id = 3, Name = "3"};
            BusinessEntity mappedBusiness = this.mapper.Map<BusinessEntity>(databaseEntity);

            // mappedBusiness id == 3; name == "3" as expected
            mappedBusiness.Should().BeEquivalentTo(databaseEntity);

            var wrappedNoConditions = new WrapperEntityNoPreconditions();
            DatabaseEntity mappedFromWrappedNoConditions = this.mapper.Map<DatabaseEntity>(wrappedNoConditions);

            // mappedFromWrappedNoConditions id == 4; name == "4" as expected
            mappedFromWrappedNoConditions.Id.Should().Be(wrappedNoConditions.GetInstance().Id);
            mappedFromWrappedNoConditions.Name.Should().Be(wrappedNoConditions.GetInstance().Name);

            var wrapped = new WrapperEntity();
            DatabaseEntity mappedFromWrapped = this.mapper.Map<DatabaseEntity>(wrapped);

            // mappedFromWrapped id == 0; name == null
            // Expected: name == "1"; id == 0;
            // For all members is not called
            mappedFromWrapped.Name.Should().Be(wrapped.GetInstance().Name);
            mappedFromWrapped.Id.Should().Be(default);
        }

[ahaugedk]

Actually, you don't need to use ForAllMembers() you will get the same issue if you do ForMember() on a property from the Included member.
Test.zip

[lbargaoanu]

Yes, merging configuration between the main map and the included map is kind of messy. Not allowing it seems best. For a given member, you either configure everything in the main map, or in the included map.

[ahaugedk]

I was using:

ForAllMaps((typeMap, mappingExpression) => mappingExpression.ForAllMembers(opts => opts.Condition((object source, object target, object sourceValue) => sourceValue != null)));

In order to patch objects and avoid mapping null source values. With this issue, I can no longer do this. Is this not a supported usage scenario?

[NightRiderX11]

Maybe you can try this

cfg.ForAllMaps((a, b) => { if(!a.IncludedMembers.Any()) { b.ForAllMembers(opt => opt.Condition((src, dest, sourceValue ) => sourceValue != null)); } });