Fix server html insertion target (vercel#42591)

huozhi · web-flow · commit 01a1a7f1e7ae · 2022-11-07T18:16:13.000+01:00
Fixes vercel#42493 Make sure searching for the close head tag instead of partial of head tag ## Bug - [x] Related issues linked using `fixes #number` - [x] Integration tests added - [ ] Errors have a helpful link attached, see `contributing.md`
diff --git a/packages/next/server/node-web-streams-helper.ts b/packages/next/server/node-web-streams-helper.ts
@@ -173,7 +173,7 @@ function createHeadInsertionTransformStream(
         freezing = true
       } else {
         const content = decodeText(chunk)
-        const index = content.indexOf('</head')
+        const index = content.indexOf('</head>')
         if (index !== -1) {
           const insertedHeadContent =
             content.slice(0, index) + insertion + content.slice(index)
diff --git a/test/.gitignore b/test/.gitignore
@@ -1 +1,2 @@
 !node_modules
+.vscode
diff --git a/test/e2e/app-dir/app-alias/next.config.js b/test/e2e/app-dir/app-alias/next.config.js
@@ -1,6 +1,5 @@
 module.exports = {
   experimental: {
     appDir: true,
-    transpileModules: ['ui'],
   },
 }
diff --git a/test/e2e/app-dir/app-alias/src/app/layout.tsx b/test/e2e/app-dir/app-alias/src/app/layout.tsx
@@ -1,8 +1,10 @@
 export default function Root({ children }: { children: React.ReactNode }) {
   return (
     <html>
-      <head></head>
-      <body>{children}</body>
+      <body>
+        <header>top bar</header>
+        {children}
+      </body>
     </html>
   )
 }

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,5 @@`
`1`	`1`	`module.exports = {`
`2`	`2`	`experimental: {`
`3`	`3`	`appDir: true,`
`4`		`- transpileModules: ['ui'],`
`5`	`4`	`},`
`6`	`5`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,10 @@`
`1`	`1`	`export default function Root({ children }: { children: React.ReactNode }) {`
`2`	`2`	`return (`
`3`	`3`	`<html>`
`4`		`- <head></head>`
`5`		`- <body>{children}</body>`
	`4`	`+ <body>`
	`5`	`+ <header>top bar</header>`
	`6`	`+ {children}`
	`7`	`+ </body>`
`6`	`8`	`</html>`
`7`	`9`	`)`
`8`	`10`	`}`