-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update testing README #2855
Update testing README #2855
Conversation
clang-tidy review says "All clean, LGTM! 👍" |
edf9a4e
to
5d165f8
Compare
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
clang-tidy review says "All clean, LGTM! 👍" |
cb5f167
to
209526c
Compare
I've updated the testing instructions to reflect the latest changes in testing code. @Lestropie could you please have a look and see if there's anything that's missing and/or incorrect? |
clang-tidy review says "All clean, LGTM! 👍" |
209526c
to
b4d638b
Compare
clang-tidy review says "All clean, LGTM! 👍" |
clang-tidy review says "All clean, LGTM! 👍" |
|
I think you've removed the section on using a local clone to download the test data. Shall we omit that in the testing readme? I think it'd be for that mechanism to be documented somewhere at least. |
Good catch. Think I failed to move it partway through, then erroneously deleted it entirely when I had to do an explicit rebase. |
clang-tidy review says "All clean, LGTM! 👍" |
This seems to be good to go IMO, so will merge soon. |
Addresses #2826.
Testing tips and instructions have been updated to reflect the transition to CMake. Sections on the handling of testing data assume #2848 has been merged.
Some instructions may not be clear or need removing due to the fact that some of the concerns/workflows no longer apply with the transition to CMake.
It's still WIP.