New command: dirrotate #2943
Merged
New command: dirrotate #2943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
daljit46
reviewed
Jul 17, 2024
- For many dir* commands, rename -permutations to -number, since in some cases the operation being performed is not strictly permutation. - dirrotate: Resolve some recommendations from clang-tidy. - dirrotate: Make use of MutexProtected<> class.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Conflicts: testing/binaries/CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2749.
Have had a lot of issues locally with getting DWI protocols to execute reliably without yielding scanner hardware complaints or outright termination. One of many contributing factors was the presence of volumes for which the direction of diffusion sensitisation aligns very closely with one of the scanner physical axes. This maximises power amplifier & cooling load, and risks exceeding peak amplitude capability once gradient pre-emphasis is added.
This command finds (via brute force) an axis & angle of rotation for which its application results in the minimum of maximum cosines across the direction set. By integrating this into my scheme generation script, I was able to reduce the maximal requested gradient amplitude from 0.995 to 0.980. There is zero consequence to other aspects of the scheme such as nearest neighbour angles and SH transform condition number.