Download NifTI headers from remote host #2979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
Lestropie
reviewed
Aug 30, 2024
|
clang-tidy review says "All clean, LGTM! 👍" |
Lestropie
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Made some suggestions to the documentation. Check code flagged in comment, as well as #2980 (but happy for this to be merged in the absence of the latter)
|
clang-tidy review says "All clean, LGTM! 👍" |
|
I think #2980 is beyond this PR's scope so I will merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #2978. Developers can still provide the headers locally by creating a
niftidirectory inMRTRIX_DEPENDENCIES_DIR.