Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show full coverage report on new / modified files #38

Closed
pavelfomin opened this issue Feb 9, 2023 · 3 comments
Closed

Show full coverage report on new / modified files #38

pavelfomin opened this issue Feb 9, 2023 · 3 comments
Assignees
Labels
feature request New feature or request incubation Features that are under discussion
Milestone

Comments

@pavelfomin
Copy link

Thank you for making this action available! One suggestion I have is to include full coverage report for new / modified files.
Typically, to approve a PR I would like to see the full coverage report on new / modified files (w/out checking out the branch and running the build to generate the full code coverage report locally):
image
Would be nice to have this feature.

@thsaravana thsaravana added the feature request New feature or request label Jul 25, 2023
@thsaravana thsaravana added this to the 1.7 milestone Jul 25, 2023
@thsaravana
Copy link
Member

It's not possible to add the full jacoco report to the PR comment. That would be really long. May be, we can expose this report in the Github workflow run.
Let me see if we can do that!

@thsaravana thsaravana self-assigned this Jul 25, 2023
@thsaravana thsaravana added the incubation Features that are under discussion label Jul 25, 2023
@MichaelMiles
Copy link

yeah it would be nice to have a full jacoco report shown somewhere, is this feature in progress?

@instrap
Copy link
Member

instrap commented Sep 8, 2024

I took a look at this, and this doesn't seem to be feasible. The easiest option would be to just add another step in your workflow to upload the Coverage html package. Trying to implement what jacoco does is a huge venture.
We are working on a couple of things that will enable this partially. #88 #60 #67 . But there is no plans to upload the full html as part of this action. So closing this.

@instrap instrap closed this as completed Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request incubation Features that are under discussion
Projects
None yet
Development

No branches or pull requests

4 participants