Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "Kubernetes-Style" labels for aggregation #34

Open
michaelharrer opened this issue Oct 9, 2019 · 2 comments
Open

Allow "Kubernetes-Style" labels for aggregation #34

michaelharrer opened this issue Oct 9, 2019 · 2 comments

Comments

@michaelharrer
Copy link

When I try to aggregate on an annotation or label in this format:

labels:
  app/name: "appname"
  helm/release: "releasename"

the bucketaggregation will fail due to the char /
Seems like it is a problem with ES client library.

@Zandrael
Copy link

Zandrael commented Oct 24, 2019

thx for this issue report

Regarding to the official documation for k8s labels (https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/), there are officially recommended k8s labels like "app.kubernetes.io/name". So it would be awesome, if elcep could support them.

currently we have to add additional non prefixed labels as workaround, which results in some terrible redundancy, like that:

helm/release: "release-name"
release: "release-name"
app/name: "app-name"
app: "app-name"

@RafalMaleska
Copy link

Will this issue be included in the backlog for the upcoming releases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants