Skip to content

Commit 0a93ca2

Browse files
MaikuBrunner
and
runner
authored
[flutter_local_notifications] resolved redundant default values warning in unit tests (#2046)
* resolved redundant default values warning for unit tests * Clang Format --------- Co-authored-by: runner <[email protected]>
1 parent 6a2bbe5 commit 0a93ca2

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

flutter_local_notifications/ios/Classes/FlutterLocalNotificationsPlugin.m

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ @implementation FlutterLocalNotificationsPlugin {
4141
NSString *const REQUEST_SOUND_PERMISSION = @"requestSoundPermission";
4242
NSString *const REQUEST_ALERT_PERMISSION = @"requestAlertPermission";
4343
NSString *const REQUEST_BADGE_PERMISSION = @"requestBadgePermission";
44-
NSString *const REQUEST_PROVISIONAL_PERMISSION = @"requestProvisionalPermission";
44+
NSString *const REQUEST_PROVISIONAL_PERMISSION =
45+
@"requestProvisionalPermission";
4546
NSString *const REQUEST_CRITICAL_PERMISSION = @"requestCriticalPermission";
4647
NSString *const DEFAULT_PRESENT_ALERT = @"defaultPresentAlert";
4748
NSString *const DEFAULT_PRESENT_SOUND = @"defaultPresentSound";
@@ -420,8 +421,10 @@ - (void)initialize:(NSDictionary *_Nonnull)arguments
420421
if ([self containsKey:REQUEST_BADGE_PERMISSION forDictionary:arguments]) {
421422
requestedBadgePermission = [arguments[REQUEST_BADGE_PERMISSION] boolValue];
422423
}
423-
if([self containsKey:REQUEST_PROVISIONAL_PERMISSION forDictionary:arguments]) {
424-
requestedProvisionalPermission = [arguments[REQUEST_PROVISIONAL_PERMISSION] boolValue];
424+
if ([self containsKey:REQUEST_PROVISIONAL_PERMISSION
425+
forDictionary:arguments]) {
426+
requestedProvisionalPermission =
427+
[arguments[REQUEST_PROVISIONAL_PERMISSION] boolValue];
425428
}
426429
if ([self containsKey:REQUEST_CRITICAL_PERMISSION forDictionary:arguments]) {
427430
requestedCriticalPermission =
@@ -443,7 +446,7 @@ - (void)initialize:(NSDictionary *_Nonnull)arguments
443446
[self requestPermissionsImpl:requestedSoundPermission
444447
alertPermission:requestedAlertPermission
445448
badgePermission:requestedBadgePermission
446-
provisionalPermission: requestedProvisionalPermission
449+
provisionalPermission:requestedProvisionalPermission
447450
criticalPermission:requestedCriticalPermission
448451
result:result];
449452
}];
@@ -476,15 +479,15 @@ - (void)requestPermissions:(NSDictionary *_Nonnull)arguments
476479
[self requestPermissionsImpl:soundPermission
477480
alertPermission:alertPermission
478481
badgePermission:badgePermission
479-
provisionalPermission: provisionalPermission
482+
provisionalPermission:provisionalPermission
480483
criticalPermission:criticalPermission
481484
result:result];
482485
}
483486

484487
- (void)requestPermissionsImpl:(bool)soundPermission
485488
alertPermission:(bool)alertPermission
486489
badgePermission:(bool)badgePermission
487-
provisionalPermission:(bool)provisionalPermission
490+
provisionalPermission:(bool)provisionalPermission
488491
criticalPermission:(bool)criticalPermission
489492
result:(FlutterResult _Nonnull)result {
490493
if (!soundPermission && !alertPermission && !badgePermission &&
@@ -507,7 +510,7 @@ - (void)requestPermissionsImpl:(bool)soundPermission
507510
authorizationOptions += UNAuthorizationOptionBadge;
508511
}
509512
if (@available(iOS 12.0, *)) {
510-
if(provisionalPermission) {
513+
if (provisionalPermission) {
511514
authorizationOptions += UNAuthorizationOptionProvisional;
512515
}
513516
if (criticalPermission) {

flutter_local_notifications/test/ios_flutter_local_notifications_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,6 @@ void main() {
170170
requestAlertPermission: false,
171171
requestBadgePermission: false,
172172
requestSoundPermission: false,
173-
requestProvisionalPermission: false,
174173
defaultPresentAlert: false,
175174
defaultPresentBadge: false,
176175
defaultPresentSound: false,

flutter_local_notifications/test/macos_flutter_local_notifications_test.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ void main() {
6666
requestAlertPermission: false,
6767
requestBadgePermission: false,
6868
requestSoundPermission: false,
69-
requestProvisionalPermission: false,
7069
defaultPresentAlert: false,
7170
defaultPresentBadge: false,
7271
defaultPresentSound: false,

0 commit comments

Comments
 (0)