[flutter_local_notifications] lower Flutter SDK to hotfix 5 due to pub issues and optimise usage of Gson (#464)

* reuse gson instance

* change flutter sdk requirement

* use ArgumentError.checkNotNull and mention removal of upper SDK constraint in changelog

Author: MaikuB

flutter_local_notifications/CHANGELOG.md

@@ -1,6 +1,11 @@
+# [1.1.5]
+* [Android] minor optimisation on scheduling related code so that `Gson` instance is reused instead of being rebuilt each time
+* Changed plugin to require 1.12.3+hotfix.5 or greater since pub has issues resolving 1.12.3+hotfix.6
+* Updated changelog entry for version 1.1.4 to mention removal of upper bound constraint on Flutter SDK requirement
+
 # [1.1.4]
 * Support v2 Android embedding. Note that there is currently a [known issue](https://github.com/flutter/flutter/issues/49365) in the Flutter SDK that will cause `onSelectNotification` to fire twice on Android. The fix is in the master channel but hasn't rolled out to other channels. Subscribe to the issue for updates.
-* Require Flutter SDK 1.12.3+hotfix.6 or greater
+* Require Flutter SDK 1.12.3+hotfix.6 or greater. Maximum SDK restraint has also been removed
 
 # [1.1.3]
 * Expose `NotificationAppLaunchDetails` via main plugin

flutter_local_notifications/android/src/main/java/com/dexterous/flutterlocalnotifications/FlutterLocalNotificationsPlugin.java

@@ -98,6 +98,7 @@ public class FlutterLocalNotificationsPlugin implements MethodCallHandler, Plugi
     private MethodChannel channel;
     private Context applicationContext;
     private Activity mainActivity;
+    static Gson gson;
 
 
     public static void registerWith(Registrar registrar) {
@@ -124,7 +125,6 @@ public void onAttachedToEngine(FlutterPluginBinding binding) {
 
     @Override
     public void onDetachedFromEngine(FlutterPluginBinding binding) {
-
     }
 
     @Override
@@ -215,16 +215,19 @@ private static void setSmallIcon(Context context, NotificationDetails notificati
 
     @NonNull
     static Gson buildGson() {
-        RuntimeTypeAdapterFactory<StyleInformation> styleInformationAdapter =
-                RuntimeTypeAdapterFactory
-                        .of(StyleInformation.class)
-                        .registerSubtype(DefaultStyleInformation.class)
-                        .registerSubtype(BigTextStyleInformation.class)
-                        .registerSubtype(BigPictureStyleInformation.class)
-                        .registerSubtype(InboxStyleInformation.class)
-                        .registerSubtype(MessagingStyleInformation.class);
-        GsonBuilder builder = new GsonBuilder().registerTypeAdapterFactory(styleInformationAdapter);
-        return builder.create();
+        if(gson == null) {
+            RuntimeTypeAdapterFactory<StyleInformation> styleInformationAdapter =
+                    RuntimeTypeAdapterFactory
+                            .of(StyleInformation.class)
+                            .registerSubtype(DefaultStyleInformation.class)
+                            .registerSubtype(BigTextStyleInformation.class)
+                            .registerSubtype(BigPictureStyleInformation.class)
+                            .registerSubtype(InboxStyleInformation.class)
+                            .registerSubtype(MessagingStyleInformation.class);
+            GsonBuilder builder = new GsonBuilder().registerTypeAdapterFactory(styleInformationAdapter);
+            gson = builder.create();
+        }
+        return gson;
     }
 
     private static ArrayList<NotificationDetails> loadScheduledNotifications(Context context) {

flutter_local_notifications/example/pubspec.yaml

@@ -25,5 +25,5 @@ flutter:
 
 environment:
   sdk: ">=2.0.0-dev.28.0 <3.0.0"
-  flutter: ">=1.12.13+hotfix.6"
+  flutter: ">=1.12.13+hotfix.5"
 

flutter_local_notifications/lib/src/helpers.dart

@@ -1,10 +1,7 @@
 /// Helper method for validating notification IDs.
 /// Ensures IDs are valid 32-bit integers.
 void validateId(int id) {
-  if (id == null) {
-    throw ArgumentError.notNull('id');
-  }
-
+  ArgumentError.checkNotNull(id, 'id');
   if (id > 0x7FFFFFFF || id < -0x80000000) {
     throw ArgumentError.value(id, 'id',
         'must fit within the size of a 32-bit integer i.e. in the range [-2^31, 2^31 - 1]');

flutter_local_notifications/pubspec.yaml

@@ -1,6 +1,6 @@
 name: flutter_local_notifications
 description: A cross platform plugin for displaying and scheduling local notifications for Flutter applications with the ability to customise for each platform.
-version: 1.1.4
+version: 1.1.5
 homepage: https://github.com/MaikuB/flutter_local_notifications/tree/master/flutter_local_notifications
 
 dependencies:
@@ -31,4 +31,4 @@ flutter:
 
 environment:
   sdk: ">=2.0.0-dev.28.0 <3.0.0"
-  flutter: ">=1.12.13+hotfix.6"
+  flutter: ">=1.12.13+hotfix.5"