release: 0.5.0 for eslint 8 & es2024

Author: lwr

README.md

@@ -7,7 +7,7 @@
 
 ## Important Note
 
-Since eslint 6 changes it's config resolving mechanism, config module can not share outside project root.
+Since eslint 6 changes its config resolving mechanism, config module can not share outside project root.
 
 <ins>**This project has been changed to a plugin module and renamed (only package name).**</ins>
 
@@ -20,8 +20,8 @@ To use this config, add this to your `package.json`
 ```json
 {
   "devDependencies"  : {
-    "eslint"                 : "7.4.0",
-    "eslint-plugin-coremail" : "0.4.1"
+    "eslint"                 : "8.46.0",
+    "eslint-plugin-coremail" : "0.5.0"
   }
 }
 ```
@@ -51,7 +51,7 @@ Then, add this to your `.eslintrc.yaml` file:
 ## Learn more
 
 For the full listing of rules that eslint supports, and more, visit 
-For more information the full listing of rules, editor plugins, FAQs, and more, visit the
+For more information on the full listing of rules, editor plugins, FAQs, and more, visit the
 [ESLint official site](http://eslint.org/docs/rules/).
 
 ## License

config/compliant.js

@@ -1,14 +1,12 @@
 /**
- * Copyright (c) 2020 Coremail.cn, Ltd. All Rights Reserved.
+ * Copyright (c) 2023 Coremail.cn, Ltd. All Rights Reserved.
  */
 
 const error = 'error';
 
 module.exports = {
 
-    parserOptions : {
-        ecmaVersion : 3,
-    },
+    parserOptions : {ecmaVersion : 3, allowReserved : true},
 
     rules : {
         /* eslint-disable indent *//* @formatter:off */

config/standard.js

@@ -1,20 +1,16 @@
 /**
- * Copyright (c) 2020 Coremail.cn, Ltd. All Rights Reserved.
+ * Copyright (c) 2023 Coremail.cn, Ltd. All Rights Reserved.
  */
 
-const error = 'error', off = 'off', first = 'first';
+const error = 'error', off = 'off', first = 'first', never = 'never';
 
 module.exports = {
 
-    extends : ['standard'],
-
-    parserOptions : {
-        ecmaVersion : 2020,
-    },
+    extends       : ['standard'],
+    parserOptions : { ecmaVersion : 2024 },
 
+    /* eslint-disable indent */// @formatter:off
     rules : {
-        /* eslint-disable indent *//* @formatter:off */
-
         'no-var'                        : [error],
         'no-tabs'                       : [error],
         'indent'                        : [error, 4, {
@@ -29,10 +25,10 @@ module.exports = {
                                                 MemberExpression    : off,
                                                 ignoreComments      : true,
                                           }],
-        'semi'                          : [off, 'never'],
+        'semi'                          : [off, never],
         'quotes'                        : [error, 'single', 'avoid-escape'],
         'arrow-parens'                  : [error, 'as-needed'],
-        'operator-linebreak'            : [error, 'before'], // corrected now, ternary operator should has nothing special
+        'operator-linebreak'            : [error, 'before'], // corrected now, ternary operator should have nothing special
         'comma-dangle'                  : [error, { // more friendly to VCS system / manual code arrangements
                                                 arrays    : 'always-multiline',
                                                 objects   : 'always-multiline',
@@ -52,7 +48,7 @@ module.exports = {
         'dot-notation'                  : [off],
         'quote-props'                   : [off],
         'object-curly-spacing'          : [off],
-        'space-before-function-paren'   : [error, {named: 'never', anonymous: 'ignore', asyncArrow: 'always'}],
+        'space-before-function-paren'   : [error, {named: never, anonymous: 'ignore', asyncArrow: 'always'}],
         'space-before-blocks'           : [error],
         'no-multiple-empty-lines'       : [off],
         'no-multi-spaces'               : [error, {
@@ -65,5 +61,15 @@ module.exports = {
         'space-infix-ops'               : [error],
         'spaced-comment'                : [error],
         'eol-last'                      : [error],
+        'camelcase'                     : [error, {
+                                                properties          : never,
+                                                ignoreDestructuring : true,
+                                                ignoreGlobals       : true,
+                                          }],
+        'multiline-ternary'             : [off],
+        'array-callback-return'         : [off],
+        'no-empty'                      : [off],
+        'n/no-path-concat'              : [off],
+        'n/no-exports-assign'           : [off],
     },
 };

package.json

@@ -1,7 +1,7 @@
 {
   "name"             : "eslint-plugin-coremail",
   "description"      : "Javascript Standard Style - ESLint Shareable Config for coremail.cn",
-  "version"          : "0.4.1",
+  "version"          : "0.5.0",
   "author"           : {
     "name"  : "William Leung",
     "email" : "[email protected]"
@@ -28,19 +28,18 @@
   },
 
   "peerDependencies" : {
-    "eslint" : "^7.4.0"
+    "eslint" : "^8.46.0"
   },
 
   "devDependencies"  : {
-    "eslint" : "~7.4.0"
+    "eslint" : "~8.46.0"
   },
 
   "dependencies"     : {
-    "eslint-plugin-promise"  : "~4.2.1",
-    "eslint-plugin-import"   : "~2.22.0",
+    "eslint-plugin-promise"  : "~6.1.1",
+    "eslint-plugin-import"   : "~2.28.0",
     "eslint-plugin-node"     : "~11.1.0",
-    "eslint-plugin-standard" : "~4.0.1",
-    "eslint-config-standard" : "~14.1.1"
+    "eslint-config-standard" : "~17.1.0"
   },
 
   "eslintConfig"     : {

test/samples/es3/.eslintrc

@@ -0,0 +1,4 @@
+
+---
+root    : true
+extends : "../../../config/compliant.js"

test/samples/es3/es3-sample.js

@@ -0,0 +1,21 @@
+//
+
+console.log([
+    1,
+    2,
+    'never comma-dangle'
+], {
+    'var' : 'keyword must be quoted',
+    KKKKK : keywords({'long'  : long(), 'final' : final()}),
+    last  : 'never comma-dangle'
+});
+
+function keywords(x, long, final) {
+    return console.log(x['long'], x['final'], long, final);
+}
+
+function long() {
+}
+
+function final() {
+}

test/samples/sample3-spaces.js

@@ -1,6 +1,6 @@
 //
 
-// noinspection NpmUsedModulesInstalled
+// noinspection ES6UnusedImports
 import {Component} from 'react'
 
 // noinspection JSUnusedLocalSymbols
@@ -18,11 +18,11 @@ function foo(_x, y, z) {
         for (let j = 0; j < 10; j++) {
             switch (j) {
             case 0:
-                // noinspection JSUndeclaredVariable
+                // noinspection JSUndeclaredVariable, JSUnresolvedReference
                 value = "zero";
                 break;
             case 1:
-                // noinspection JSUndeclaredVariable
+                // noinspection JSUndeclaredVariable, JSUnresolvedReference
                 value = "one";
                 break;
             }

test/samples/sample4-wrapping.js

@@ -1,6 +1,6 @@
 //
 
-// noinspection NpmUsedModulesInstalled
+// noinspection JSUnresolvedReference, ES6UnusedImports
 import {
     Component,
     property1,
@@ -24,8 +24,8 @@ let foo = {
         b : {id : 456, type : "Int"},
     },
 // fBar : function (x,y);
-    fOne    : function (a, b, c, d,
-                        e, f, g, h) {
+    fOne    : function (a, b, c, d, e,
+                        f, g, h, i, j) {
         // noinspection JSUnusedLocalSymbols
         let x = a
                 + b
@@ -43,7 +43,6 @@ let foo = {
         // noinspection JSUnusedAssignment
         z = a === 10 ? 'yes' : 'no';
         let colors = ['red', 'green', 'blue', 'black', 'white', 'gray'];
-        // noinspection JSUndeclaredVariable
         for (j = 0; j < 2; j++) i = a;
         // noinspection JSUnusedLocalSymbols, ES6ConvertVarToLetConst
         for (let i = 0; i
@@ -54,7 +53,7 @@ let foo = {
 
     chainedCallSample(a, b, c, d,
                       e, f, g, h) {
-        // noinspection JSUnresolvedVariable, JSUnresolvedFunction, ES6ModulesDependencies, JSValidateTypes
+        // noinspection JSUnresolvedVariable, JSUnresolvedFunction, ES6ModulesDependencies, JSValidateTypes, JSCheckFunctionSignatures
         chainRoot.firstCall(a, b, c, d,
             e, f, g, h).secondCall(a, b, c, d).thirdCall(a, b, c, d).fourthCall().q(a).r(a, b).s();
         // noinspection JSUnresolvedVariable, JSUnresolvedFunction, ES6ModulesDependencies, JSValidateTypes
@@ -70,12 +69,12 @@ let foo = {
     /**
      * Function JSDoc. Long lines can be wrapped with 'Comments'/'Wrap at right margin' option
      * @param {string} a Parameter A description.
-     * @param {string} b Parameter B description. Can extend beyond the right margin.
+     * @param {string} b Parameter B description. It can extend beyond the right margin.
      */
     fTwo : function (a, b, c, d) {
-        // noinspection JSUnresolvedFunction
-        foo(a, b, c, d); // Line comment which can be wrapped if long.
-        // noinspection ConstantIfStatementJS
+        // noinspection JSUnresolvedFunction, JSValidateTypes
+        foo(a, b, c, d); // line comment which can be wrapped if long.
+        // noinspection ConstantIfStatementJS, PointlessBooleanExpressionJS
         if (true) {
             return c;
         }
@@ -134,6 +133,7 @@ let foo = {
     },
 };
 
+// noinspection NpmUsedModulesInstalled
 funDeclare(require('jquery'), 300, 20, 10);
 
 function funDeclare($,
@@ -144,5 +144,5 @@ function funDeclare($,
     )));
 }
 
-/* eslint curly:            "off"       */
-/* eslint brace-style:      "off"       */
+/* eslint curly: off */
+/* eslint brace-style: off */