Skip to content

Commit 36a99a4

Browse files
authored
Merge pull request #60 from Fryguy/fix_logger_issues
Fix issues where active_support does not require logger properly
2 parents 7234feb + 6b240c2 commit 36a99a4

File tree

4 files changed

+4
-3
lines changed

4 files changed

+4
-3
lines changed

bin/console

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22

33
require "bundler/setup"
44
require "ovirt_metrics"
5-
require "pry"
65

7-
Pry.start
6+
require "irb"
7+
IRB.start

lib/ovirt_metrics.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
require "logger" # Require logger due to active_support breaking on Rails <= 7.0. See https://github.com/rails/rails/pull/54264
12
require "active_record"
23
require "ovirt_metrics/version"
34
require "ovirt_metrics/configurator"

spec/spec_helper.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,5 @@
9797
end
9898
ActiveRecord::Base.establish_connection :adapter => "sqlite3", :database => ":memory:"
9999

100-
require "active_record"
101100
puts
102101
puts "\e[93mUsing ActiveRecord #{ActiveRecord.version}\e[0m"

spec/support/active_record.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
require "logger" # Require logger due to active_support breaking on Rails <= 7.0. See https://github.com/rails/rails/pull/54264
12
require 'active_record'
23

34
module ActiveModel::Validations

0 commit comments

Comments
 (0)