Skip to content

Commit 63a7a4d

Browse files
authored
Merge pull request #2 from ryansolid/fix-svg-a
Fix svg anchor
2 parents 734ecfc + b42d4f5 commit 63a7a4d

File tree

3 files changed

+6
-32
lines changed

3 files changed

+6
-32
lines changed

package-lock.json

+4-30
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ function isValidHTMLNesting(parent, child) {
3838
}
3939

4040
// svg tags should only contain svg tags
41-
if (svgTags.has(parent) && !svgTags.has(child)) {
41+
if (svgTags.has(parent) && child !== "a" && !svgTags.has(child)) {
4242
return false;
4343
}
4444

tests/validation.test.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ test('svg', () => {
109109
expect(isValidHTMLNesting('svg', 'p')).toBe(false);
110110

111111
// valid
112-
expect(isValidHTMLNesting('svg', 'a')).toBe(false);
112+
expect(isValidHTMLNesting('svg', 'a')).toBe(true);
113113
expect(isValidHTMLNesting('svg', 'g')).toBe(true);
114114
expect(isValidHTMLNesting('svg', 'ellipse')).toBe(true);
115115
expect(isValidHTMLNesting('div', 'svg')).toBe(true);

0 commit comments

Comments
 (0)