Skip to content

Commit e8d16fd

Browse files
committed
add note to opt_const_param_of
1 parent 7e11379 commit e8d16fd

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

  • src/librustc_middle/query

src/librustc_middle/query/mod.rs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,13 @@ rustc_queries! {
103103
/// // ^ While calling `opt_const_param_of` for other bodies returns `None`.
104104
/// }
105105
/// ```
106+
// It looks like caching this query on disk actually slightly
107+
// worsened performance in #74376.
108+
//
109+
// Once const generics are more prevalently used, we might want to
110+
// consider only caching calls returning `Some`.
106111
query opt_const_param_of(key: LocalDefId) -> Option<DefId> {
107112
desc { |tcx| "computing the optional const parameter of `{}`", tcx.def_path_str(key.to_def_id()) }
108-
// FIXME(#74113): consider storing this query on disk.
109113
}
110114

111115
/// Records the type of every item.

0 commit comments

Comments
 (0)