Skip to content

Commit 9522027

Browse files
authored
Fix bug in query handling where map-meta in query response was (#888)
inadvertently ignored. Rename _layer.metas to _layer.queryMetas for clarity.
1 parent 3aaa9d1 commit 9522027

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

src/map-feature.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,9 @@ export class MapFeature extends HTMLElement {
345345
let map = this._map,
346346
geometry = this.querySelector('map-geometry'),
347347
native = this._getNativeZoomAndCS(
348-
this._layer._content || this._layer.metas
348+
this._layer.queryMetas?.length
349+
? this._layer.queryMetas
350+
: this._layer._content
349351
),
350352
cs = geometry.getAttribute('cs') || native.cs,
351353
// zoom level that the feature rendered at

src/mapml/handlers/QueryHandler.js

+7-3
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,8 @@ export var QueryHandler = L.Handler.extend({
113113
features = Array.prototype.slice.call(
114114
mapmldoc.querySelectorAll('map-feature')
115115
);
116-
// <map-meta> elements
117-
layer.metas = Array.prototype.slice.call(
116+
// <map-meta> elements for this query
117+
layer.queryMetas = Array.prototype.slice.call(
118118
mapmldoc.querySelectorAll(
119119
'map-meta[name=cs], map-meta[name=zoom], map-meta[name=projection]'
120120
)
@@ -298,7 +298,11 @@ export var QueryHandler = L.Handler.extend({
298298
layer.on('popupclose', function () {
299299
map.removeLayer(f);
300300
});
301-
f.showPaginationFeature({ i: 0, popup: layer._popup, meta: layer.metas });
301+
f.showPaginationFeature({
302+
i: 0,
303+
popup: layer._popup,
304+
meta: layer.queryMetas
305+
});
302306
}
303307
}
304308
});

0 commit comments

Comments
 (0)