#4565 Add input validation to InMemorySessionStore

joshhanson314 · claude · joshhanson314 · commit bfcd9243f416 · 2026-02-19T14:18:55.000-05:00
Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/Source/Csla.AspNetCore/Blazor/State/InMemorySessionStore.cs b/Source/Csla.AspNetCore/Blazor/State/InMemorySessionStore.cs
@@ -22,20 +22,24 @@ public class InMemorySessionStore : ISessionStore
   /// <inheritdoc />
   public ValueTask<Session?> GetSessionAsync(string key)
   {
+    ArgumentNullException.ThrowIfNull(key);
     _sessions.TryGetValue(key, out var session);
     return new ValueTask<Session?>(session);
   }
 
   /// <inheritdoc />
   public ValueTask AddOrUpdateSessionAsync(string key, Session session)
   {
+    ArgumentNullException.ThrowIfNull(key);
+    ArgumentNullException.ThrowIfNull(session);
     _sessions.AddOrUpdate(key, session, (_, _) => session);
     return ValueTask.CompletedTask;
   }
 
   /// <inheritdoc />
   public ValueTask PurgeExpiredSessionsAsync(TimeSpan expiration)
   {
+    ArgumentOutOfRangeException.ThrowIfNegative(expiration.Ticks, nameof(expiration));
     var expirationTime = DateTimeOffset.UtcNow.ToUnixTimeSeconds() - expiration.TotalSeconds;
     List<string> toRemove = [];
     foreach (var kvp in _sessions)

Original file line number	Diff line number	Diff line change
`@@ -22,20 +22,24 @@ public class InMemorySessionStore : ISessionStore`
`22`	`22`	`/// <inheritdoc />`
`23`	`23`	`public ValueTask<Session?> GetSessionAsync(string key)`
`24`	`24`	`{`
	`25`	`+ ArgumentNullException.ThrowIfNull(key);`
`25`	`26`	`_sessions.TryGetValue(key, out var session);`
`26`	`27`	`return new ValueTask<Session?>(session);`
`27`	`28`	`}`
`28`	`29`
`29`	`30`	`/// <inheritdoc />`
`30`	`31`	`public ValueTask AddOrUpdateSessionAsync(string key, Session session)`
`31`	`32`	`{`
	`33`	`+ ArgumentNullException.ThrowIfNull(key);`
	`34`	`+ ArgumentNullException.ThrowIfNull(session);`
`32`	`35`	`_sessions.AddOrUpdate(key, session, (_, _) => session);`
`33`	`36`	`return ValueTask.CompletedTask;`
`34`	`37`	`}`
`35`	`38`
`36`	`39`	`/// <inheritdoc />`
`37`	`40`	`public ValueTask PurgeExpiredSessionsAsync(TimeSpan expiration)`
`38`	`41`	`{`
	`42`	`+ ArgumentOutOfRangeException.ThrowIfNegative(expiration.Ticks, nameof(expiration));`
`39`	`43`	`var expirationTime = DateTimeOffset.UtcNow.ToUnixTimeSeconds() - expiration.TotalSeconds;`
`40`	`44`	`List<string> toRemove = [];`
`41`	`45`	`foreach (var kvp in _sessions)`