You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: docs/devel/pull-requests.md
+34-17
Original file line number
Diff line number
Diff line change
@@ -34,37 +34,54 @@ Documentation for other releases can be found at
34
34
Pull Request Process
35
35
====================
36
36
37
-
An overview of how we will manage old or out-of-date pull requests.k
38
-
Process
39
-
-------
40
-
41
-
We will close any pull requests older than two weeks.
42
-
43
-
Exceptions can be made for PRs that have active review comments, or that are awaiting other dependent PRs. Closed pull requests are easy to recreate, and little work is lost by closing a pull request that subsequently needs to be reopened.
44
-
45
-
We want to limit the total number of PRs in flight to:
46
-
* Maintain a clean project
47
-
* Remove old PRs that would be difficult to rebase as the underlying code has changed over time
48
-
* Encourage code velocity
37
+
An overview of how pull requests are managed for kubernetes. This document
38
+
assumes the reader has already followed the [development guide](development.md)
39
+
to set up their environment.
49
40
50
41
Life of a Pull Request
51
42
----------------------
52
43
53
-
### Visual overview
54
-
55
-

56
-
57
44
Unless in the last few weeks of a milestone when we need to reduce churn and stabilize, we aim to be always accepting pull requests.
58
45
59
46
Either the [on call](https://github.com/kubernetes/kubernetes/wiki/Kubernetes-on-call-rotations) manually or the [github "munger"](https://github.com/kubernetes/contrib/tree/master/mungegithub) submit-queue plugin automatically will manage merging PRs.
60
47
61
48
There are several requirements for the submit-queue to work:
62
49
* Author must have signed CLA ("cla: yes" label added to PR)
63
50
* No changes can be made since last lgtm label was applied
64
-
* k8s-bot must have reported the GCE E2E build and test steps passed (Travis, Shippable and Jenkins build)
51
+
* k8s-bot must have reported the GCE E2E build and test steps passed (Travis, Jenkins unit/integration, Jenkins e2e)
65
52
66
53
Additionally, for infrequent or new contributors, we require the on call to apply the "ok-to-merge" label manually. This is gated by the [whitelist](https://github.com/kubernetes/contrib/blob/master/mungegithub/whitelist.txt).
67
54
55
+
### Before sending a pull request
56
+
57
+
The following will save time for both you and your reviewer:
58
+
59
+
* Enable [pre-commit hooks](development.md#committing-changes-to-your-fork) and verify they pass.
60
+
* Verify `hack/verify-generated-docs.sh` passes.
61
+
* Verify `hack/test-go.sh` passes.
62
+
63
+
### Visual overview
64
+
65
+

66
+
67
+
Other notes
68
+
-----------
69
+
70
+
Pull requests that are purely support questions will be closed and
71
+
redirected to [stackoverflow](http://stackoverflow.com/questions/tagged/kubernetes).
72
+
We do this to consolidate help/support questions into a single channel,
73
+
improve efficiency in responding to requests and make FAQs easier
74
+
to find.
75
+
76
+
Pull requests older than 2 weeks will be closed. Exceptions can be made
77
+
for PRs that have active review comments, or that are awaiting other dependent PRs.
78
+
Closed pull requests are easy to recreate, and little work is lost by closing a pull
79
+
request that subsequently needs to be reopened. We want to limit the total number of PRs in flight to:
80
+
* Maintain a clean project
81
+
* Remove old PRs that would be difficult to rebase as the underlying code has changed over time
0 commit comments