version consistency: provide evaluation strategy to ignore filter (#29443)

Author: nrainer-materialize

misc/python/materialize/output_consistency/execution/evaluation_strategy.py

@@ -395,3 +395,17 @@ def is_other_db_evaluation_strategy(evaluation_key: EvaluationStrategyKey) -> bo
         EvaluationStrategyKey.MZ_DATAFLOW_RENDERING_OTHER_DB,
         EvaluationStrategyKey.MZ_CONSTANT_FOLDING_OTHER_DB,
     }
+
+
+def is_data_flow_rendering(evaluation_key: EvaluationStrategyKey) -> bool:
+    return evaluation_key in {
+        EvaluationStrategyKey.MZ_DATAFLOW_RENDERING,
+        EvaluationStrategyKey.MZ_DATAFLOW_RENDERING_OTHER_DB,
+    }
+
+
+def is_constant_folding(evaluation_key: EvaluationStrategyKey) -> bool:
+    return evaluation_key in {
+        EvaluationStrategyKey.MZ_CONSTANT_FOLDING,
+        EvaluationStrategyKey.MZ_CONSTANT_FOLDING_OTHER_DB,
+    }

misc/python/materialize/version_consistency/ignore_filter/version_consistency_ignore_filter.py

@@ -53,26 +53,31 @@
 
 
 class VersionConsistencyIgnoreFilter(GenericInconsistencyIgnoreFilter):
-    def __init__(self, mz1_version: MzVersion, mz2_version: MzVersion):
+    def __init__(self, mz1_version: MzVersion, mz2_version: MzVersion, uses_dfr: bool):
         lower_version, higher_version = (
             (mz1_version, mz2_version)
             if mz1_version < mz2_version
             else (mz2_version, mz1_version)
         )
         super().__init__(
-            VersionPreExecutionInconsistencyIgnoreFilter(lower_version, higher_version),
+            VersionPreExecutionInconsistencyIgnoreFilter(
+                lower_version, higher_version, uses_dfr
+            ),
             VersionPostExecutionInconsistencyIgnoreFilter(
-                lower_version, higher_version
+                lower_version, higher_version, uses_dfr
             ),
         )
 
 
 class VersionPreExecutionInconsistencyIgnoreFilter(
     PreExecutionInconsistencyIgnoreFilterBase
 ):
-    def __init__(self, lower_version: MzVersion, higher_version: MzVersion):
+    def __init__(
+        self, lower_version: MzVersion, higher_version: MzVersion, uses_dfr: bool
+    ):
         self.lower_version = lower_version
         self.higher_version = higher_version
+        self.uses_dfr = uses_dfr
 
     def shall_ignore_expression(
         self, expression: Expression, row_selection: DataRowSelection
@@ -184,9 +189,12 @@ def shall_ignore_expression(
 class VersionPostExecutionInconsistencyIgnoreFilter(
     PostExecutionInconsistencyIgnoreFilterBase
 ):
-    def __init__(self, lower_version: MzVersion, higher_version: MzVersion):
+    def __init__(
+        self, lower_version: MzVersion, higher_version: MzVersion, uses_dfr: bool
+    ):
         self.lower_version = lower_version
         self.higher_version = higher_version
+        self.uses_dfr = uses_dfr
 
     def _shall_ignore_success_mismatch(
         self,

misc/python/materialize/version_consistency/version_consistency_test.py

@@ -127,7 +127,14 @@ def create_inconsistency_ignore_filter(self) -> GenericInconsistencyIgnoreFilter
         assert self.mz1_version is not None
         assert self.mz2_version is not None
 
-        return VersionConsistencyIgnoreFilter(self.mz1_version, self.mz2_version)
+        assert (
+            self.evaluation_strategy_name is not None
+        ), "Evaluation strategy name is not initialized"
+
+        uses_dfr = self.evaluation_strategy_name == EVALUATION_STRATEGY_NAME_DFR
+        return VersionConsistencyIgnoreFilter(
+            self.mz1_version, self.mz2_version, uses_dfr
+        )
 
     def create_evaluation_strategies(
         self, sql_executors: SqlExecutors