Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't generate test cases for ALG_FFDH without KEY_TYPE_DH #160

Open
gilles-peskine-arm opened this issue Jan 16, 2025 · 0 comments
Open
Labels
component-test Test framework and CI scripts enhancement New feature or request size-s Estimated task size: small (~2d)

Comments

@gilles-peskine-arm
Copy link
Contributor

generate_psa_tests.py generates some test cases that depend on PSA_WANT_ALG_FFDH disabled but PSA_WANT_KEY_TYPE_DH_KEY_PAIR_BASIC enabled. This is a silly configuration that we don't test.

Goals of this task (modeled on Mbed-TLS/mbedtls#9573):

  • Don't generate such test cases.
  • Remove the exception from analyze_outcomes.py
  • Ensure that crypto_adjust_*.h auto-enables PSA_WANT_ALG_FFDH and PSA_WANT_KEY_TYPE_DH_KEY_PAIR_BASIC when the other is enabled.
  • Do the right thing for other PSA_WANT_KEY_TYPE_DH_KEY_PAIR_xxx and PSA_WANT_KEY_TYPE_DH_PUBLIC_KEY.

Note: is this auto-enabling what we want? Another way to handle this is acceptable if we decide that the goal listed here isn't the best architectural choice.

@gilles-peskine-arm gilles-peskine-arm added component-test Test framework and CI scripts enhancement New feature or request size-s Estimated task size: small (~2d) labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-test Test framework and CI scripts enhancement New feature or request size-s Estimated task size: small (~2d)
Projects
None yet
Development

No branches or pull requests

1 participant