Skip to content

make_generated_files.py --check doesn't return a failure status #244

@gilles-peskine-arm

Description

@gilles-peskine-arm

Currently on Mbed TLS development (at caaa93884c9aefb1bb416a64ea26c1a0eef29140), all.sh check_generated_files complains:

Generated file tests/suites/test_suite_ecp.generated.data not identical to the reference one tests/suites/test_suite_ecp.generated.data.ref.
Generated file tests/suites/test_suite_psa_crypto_op_fail.generated.data not identical to the reference one tests/suites/test_suite_psa_crypto_op_fail.generated.data.ref.
Generated file tests/suites/test_suite_psa_crypto_storage_format.current.data not identical to the reference one tests/suites/test_suite_psa_crypto_storage_format.current.data.ref.
Generated file tests/suites/test_suite_psa_crypto_storage_format.v0.data not identical to the reference one tests/suites/test_suite_psa_crypto_storage_format.v0.data.ref.

That's from running ./framework/scripts/make_generated_files.py --check inside tf-psa-crypto after running make -f scripts/legacy.make generated_files. But we never noticed this complaint because make_generated_files.py --check always returns 0.

Metadata

Metadata

Labels

bugSomething isn't workingsize-xsEstimated task size: extra small (a few hours at most)

Type

Projects

Status

In Progress

Status

No status

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions