issue: 1718617 Update valgrind suppression file

This commit updates the ignore file and adds macros
to remove false positive errors when running vma with
debug log verbosity.

Signed-off-by: Rafi Wiener <[email protected]>

Author: Rafi Wiener

contrib/valgrind/valgrind_vma.supp

@@ -101,7 +101,22 @@
    ...
    fun:rdma_destroy_id
 }
-
+{
+   rdma_create_event_channel
+   Memcheck:Cond
+   obj:/*librdmacm.so*
+   ...
+   fun:rdma_create_event_channel
+   fun:_ZN15neigh_table_mgrC1Ev
+}
+{
+   rdma_create_event_channel
+   Memcheck:Value8
+   obj:/*librdmacm.so*
+   ...
+   fun:rdma_create_event_channel
+   fun:_ZN15neigh_table_mgrC1Ev
+}
 # false positive verbs
 {
    libibverbs Param ibv_exp_cmd_create_qp
@@ -297,6 +312,25 @@
    ...
    fun:*release_ringEP21ring_alloc_logic_attr*
 }
+{
+   query mlx5 device
+   Memcheck:Cond
+   fun:ibv_exp_cmd_query_device
+   fun:mlx5_exp_query_device
+}
+{
+   mlx5_lock_cqs
+   Memcheck:Cond
+   fun:mlx5_lock_cqs
+   fun:mlx5_destroy_qp
+}
+{
+   mlx5_unlock_cqs
+   Memcheck:Cond
+   fun:mlx5_unlock_cqs
+   fun:mlx5_destroy_qp
+}
+
 ###########################################################
 ##### libmlx4 only
 {

src/vma/dev/cq_mgr_mlx5.cpp

@@ -781,7 +781,7 @@ void cq_mgr_mlx5::set_qp_rq(qp_mgr* qp)
 	if (0 != vma_ib_mlx5_get_cq(m_p_ibv_cq, &m_mlx5_cq)) {
 		cq_logpanic("vma_ib_mlx5_get_cq failed (errno=%d %m)", errno);
 	}
-
+	VALGRIND_MAKE_MEM_DEFINED(&m_mlx5_cq, sizeof(m_mlx5_cq));
 	cq_logfunc("qp_mgr=%p m_mlx5_cq.dbrec=%p m_mlx5_cq.cq_buf=%p", m_qp, m_mlx5_cq.dbrec, m_mlx5_cq.cq_buf);
 }
 

src/vma/dev/ib_ctx_handler.cpp

@@ -350,6 +350,7 @@ bool ib_ctx_handler::is_active(int port_num)
 		ibch_logdbg("ibv_query_port failed on ibv device %p, port %d "
 			    "(errno=%d)", m_p_ibv_context, port_num, errno);
 	}ENDIF_VERBS_FAILURE;
+	VALGRIND_MAKE_MEM_DEFINED(&port_attr.state, sizeof(port_attr.state));
 	return port_attr.state == IBV_PORT_ACTIVE;
 }
 

src/vma/dev/qp_mgr.cpp

@@ -39,6 +39,7 @@
 #include "buffer_pool.h"
 #include "cq_mgr.h"
 #include "ring_simple.h"
+#include "util/valgrind.h"
 
 #undef  MODULE_NAME
 #define MODULE_NAME 		"qpm"
@@ -621,6 +622,7 @@ int qp_mgr_eth::prepare_ibv_qp(vma_ibv_qp_init_attr& qp_init_attr)
 			qp_logerr("ibv_query_qp failed (errno=%d %m)", errno);
 			return -1;
 	} ENDIF_VERBS_FAILURE;
+	VALGRIND_MAKE_MEM_DEFINED(&tmp_ibv_qp_attr, sizeof(tmp_ibv_qp_attr));
 	uint32_t tx_max_inline = safe_mce_sys().tx_max_inline;
 	m_max_inline_data = min(tmp_ibv_qp_attr.cap.max_inline_data, tx_max_inline);
 	qp_logdbg("requested max inline = %d QP, actual max inline = %d, "

src/vma/ib/mlx5/ib_mlx5.cpp

@@ -33,7 +33,7 @@
 #ifdef HAVE_CONFIG_H
 #include "config.h"
 #endif
-
+#include "util/valgrind.h"
 #if defined(DEFINED_DIRECT_VERBS)
 
 #include "vma/util/valgrind.h"
@@ -59,7 +59,7 @@ int vma_ib_mlx5_get_qp(struct ibv_qp *qp, vma_ib_mlx5_qp_t *mlx5_qp, uint32_t fl
 	if (ret != 0) {
 		goto out;
 	}
-
+	VALGRIND_MAKE_MEM_DEFINED(&dqp, sizeof(dqp));
 	mlx5_qp->qp           = qp;
 	mlx5_qp->qpn          = qp->qp_num;
 	mlx5_qp->flags        = flags;
@@ -120,7 +120,7 @@ int vma_ib_mlx5_get_cq(struct ibv_cq *cq, vma_ib_mlx5_cq_t *mlx5_cq)
 	if (ret != 0) {
 		return ret;
 	}
-
+	VALGRIND_MAKE_MEM_DEFINED(&dcq, sizeof(dcq));
 	mlx5_cq->cq           = cq;
 	mlx5_cq->cq_num       = dcq.cqn;
 	mlx5_cq->cq_ci        = 0;

src/vma/ib/mlx5/ib_mlx5_hw.cpp

@@ -33,7 +33,7 @@
 #ifdef HAVE_CONFIG_H
 #include "config.h"
 #endif
-
+#include "util/valgrind.h"
 #if defined(DEFINED_DIRECT_VERBS) && (DEFINED_DIRECT_VERBS == 2)
 
 #include "vma/ib/mlx5/ib_mlx5.h"
@@ -67,7 +67,7 @@ static int vma_ib_mlx5dv_get_qp(struct ibv_qp *qp, struct mlx5dv_qp *mlx5_qp)
 	if (ret != 0) {
 		return ret;
 	}
-
+	VALGRIND_MAKE_MEM_DEFINED(&ibv_qp_info, sizeof(ibv_qp_info));
 	mlx5_qp->dbrec      = ibv_qp_info.dbrec;
 	mlx5_qp->sq.buf     = (mqp->sq_buf_size ?
 			(void *)((uintptr_t)mqp->sq_buf.buf) : /* IBV_QPT_RAW_PACKET or Underly QP */
@@ -92,7 +92,7 @@ static int vma_ib_mlx5dv_get_cq(struct ibv_cq *cq, struct mlx5dv_cq *mlx5_cq)
 	if (ret != 0) {
 		return ret;
 	}
-
+	VALGRIND_MAKE_MEM_DEFINED(&ibv_cq_info, sizeof(ibv_cq_info));
 	mlx5_cq->buf      = ibv_cq_info.buf;
 	mlx5_cq->dbrec    = ibv_cq_info.dbrec;
 	mlx5_cq->cqe_cnt  = ibv_cq_info.cqe_cnt;