fix: general hardening

Author: MikeRalphson

adaptor.js

@@ -263,7 +263,7 @@ function convertOperation(op,verb,path,pathItem,obj,api) {
         }*/
     } // end of effective parameters
 
-    operation.operationId = op.operationId || Case.camel(op.tags[0] + (paramList ? '_' + paramList.join('_') + '_' : '') + verb);
+    operation.operationId = op.operationId || Case.camel((op.tags ? op.tags[0] :  '') + (paramList ? '_' + paramList.join('_') + '_' : '') + verb);
     operation.operationIdLowerCase = operation.operationId.toLowerCase();
     operation.operationIdSnakeCase = Case.snake(operation.operationId);
     operation.nickname = operation.operationId;
@@ -327,6 +327,7 @@ function convertOperation(op,verb,path,pathItem,obj,api) {
 
     operation.responses = [];
     for (let r in op.responses) {
+        if (!r.startsWith('x-')) {
         let response = op.responses[r];
         let entry = {};
         entry.code = r;
@@ -412,6 +413,7 @@ function convertOperation(op,verb,path,pathItem,obj,api) {
             return 0;
         });
     }
+    }
     operation.queryParams = convertArray(operation.queryParams);
     operation.headerParams = convertArray(operation.headerParams);
     operation.pathParams = convertArray(operation.pathParams);

lib/orange/downconvert.js

@@ -175,7 +175,7 @@ Converter.prototype.convertOperationParameters = function(operation) {
 Converter.prototype.convertParameters = function(obj) {
     var param;
 
-    if (obj.parameters === undefined) {
+    if (!obj || obj.parameters === undefined) {
         return;
     }
 
@@ -232,7 +232,7 @@ Converter.prototype.convertResponses = function(operation) {
         content = false;
         contentType = 'application/json';
         response = operation.responses[code] = this.resolveReference(this.spec, operation.responses[code]);
-        if (response.content) {
+        if (response && response.content) {
             if (response.content[contentType]) {
                 content = response.content[contentType];
             }
@@ -258,7 +258,7 @@ Converter.prototype.convertResponses = function(operation) {
             this.copySchemaProperties(response, SCHEMA_PROPERTIES);
         }
 
-        headers = response.headers;
+        headers = response && response.headers;
         if (headers) {
             for (var header in headers) {
                 // Always resolve headers when converting to v2.
@@ -273,7 +273,7 @@ Converter.prototype.convertResponses = function(operation) {
             }
         }
 
-        delete response.content;
+        if (response) delete response.content;
     }
 }
 

remote.js

@@ -28,15 +28,18 @@ async function main(obj, config, configName, callback) {
         headers: { 'Content-Type': 'application/json' }
     })
     .then(res => res.json())
-    .then(json => json);
-    if (response.link) {
+    .then(json => json)
+    .catch(ex => {
+      console.warn(ex.message);
+    });
+    if (response && response.link) {
         const zipfile = await fetch(response.link)
         .then(res => res.buffer())
         .then(buffer => buffer);
         callback(null, zipfile);
     }
     else {
-        console.warn(util.inspect(response));
+        if (response) console.warn(util.inspect(response));
     }
 }