You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
This is all good stuff and seems like it will run smoothly, I've added a few suggestions regarding reverts of black changes and a comment about the future unification of the keywords list which I believe we've already picked up on.
@Pierre-siddall you can open a new issue/pr to address your suggestion. This PR has already got very crowded with multiple ideas which is a digression from the original purpose. Let's get the CI workflow in first.
@Pierre-siddall you can open a new issue/pr to address your suggestion. This PR has already got very crowded with multiple ideas which is a digression from the original purpose. Let's get the CI workflow in first.
@yaswant I'll probably add these suggestions into a new issue.
The reason will be displayed to describe this comment to others. Learn more.
The previously suggested changes are better suited to a new issue or PR. Therefore as the semantics of this code looks fine I'm happy to approve this PR 😄.
Part of the intention of black is that it forces you to do the styling a single way so everything is consistent. But the last string in the suite_report suggestion is a good one to change as it won't combine strings that have already been split up so I've committed that.
As Yash suggests, the keywords work should be it's own ticket
This PR is much to large and untidy and needs to be split up. It should be fairly straight forward to separate the original workflow changes, and split off the various script changes into their own items. This shouldn't greatly increase the workload if individual components have already been reviewed.
@james-bruten-mo I was going to suggest other way around:, but since you have already done this, I suggest you bring back README changes to this branch
@james-bruten-mo I was going to suggest other way around:, but since you have already done this, I suggest you bring back README changes to this branch
Yes, I was thinking that way, but the .github changes were a lot more self-contained so easier to move!
I'll bring back the readme though
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
Prepare changes for #72
Changes
Added
Dependency
None.
Impact
None.
Issues addressed
Resolves
#51
Coordinated merge
#72
Checklist