-
Notifications
You must be signed in to change notification settings - Fork 2
Linter CI part 1 #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linter CI part 1 #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor changes in ruff.toml
|
@james-bruten-mo frustration won, eventually 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all good stuff and seems like it will run smoothly, I've added a few suggestions regarding reverts of black changes and a comment about the future unification of the keywords list which I believe we've already picked up on.
@Pierre-siddall you can open a new issue/pr to address your suggestion. This PR has already got very crowded with multiple ideas which is a digression from the original purpose. Let's get the CI workflow in first. |
@yaswant I'll probably add these suggestions into a new issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previously suggested changes are better suited to a new issue or PR. Therefore as the semantics of this code looks fine I'm happy to approve this PR 😄.
Co-authored-by: Pierre Siddall <[email protected]>
Co-authored-by: Pierre Siddall <[email protected]>
Part of the intention of black is that it forces you to do the styling a single way so everything is consistent. But the last string in the suite_report suggestion is a good one to change as it won't combine strings that have already been split up so I've committed that. |
This PR is much to large and untidy and needs to be split up. It should be fairly straight forward to separate the original workflow changes, and split off the various script changes into their own items. This shouldn't greatly increase the workload if individual components have already been reviewed. |
I've just deleted the .github directory so this is now only the styling changes. Will open a new PR for the CI in a sec... |
@james-bruten-mo I was going to suggest other way around:, but since you have already done this, I suggest you bring back |
Yes, I was thinking that way, but the .github changes were a lot more self-contained so easier to move! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost all of this is fine. A couple of minor fixes for places were black hasn't concatenated strings together properly.
Co-authored-by: Sam Clarke-Green <[email protected]>
Co-authored-by: Sam Clarke-Green <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I'm happy to approve this
Description
Summary
Prepare changes for #72
Changes
Added
Dependency
None.
Impact
None.
Issues addressed
Resolves
#51
Coordinated merge
#72
Checklist