@@ -20,13 +20,14 @@ exercises: 10
2020
2121In this section we will explore how to properly review
2222code and suggest changes if necessary.
23- Head back to your own ` weather ` repository.
23+ We will continue to work in pairs.
24+ The Owner should navigate back to their own ` weather ` repository.
2425You should see an open PR from your Collaborator.
2526
2627## Reviewing Changes
2728
28- Make sure you are on the PR your Collaborator has opened
29- on the repository you own .
29+ As the Owner make sure you are on the PR your Collaborator has opened
30+ on your repository.
3031
3132You can add general science and code review comments
3233in the ** Conversation** tab.
@@ -81,8 +82,7 @@ The PRs **Conversation** tab now looks like this:
8182
8283## Responding to Review
8384
84- Make sure you are on the PR you opened
85- on your Collaborators repository.
85+ Now it is the Collaborators turn to respond to the review.
8686
8787You can see merging is blocked because our reviewer has
8888requested changes. You also have the option to commit the
@@ -98,8 +98,7 @@ the suggested change as resolved.
9898
9999## Approving Changes
100100
101- Make sure you are on the PR your Collaborator has opened
102- on the repository you own.
101+ Now the Owner can respond to the Collaborators final changes.
103102
104103The Conversation tab should update to show the suggestion as
105104** Outdated** because it has been resolved by the Collaborator.
@@ -151,9 +150,15 @@ In the [git-novice](https://www.astropython.com/git-novice/10-pull-requests.html
151150lesson you learnt how to pull changes
152151and clean up your branches after merging a PR.
153152
154- 1 . Update your local copy of the ` weather ` repository
153+ The Collaborator can now:
154+
155+ 1 . Update their local copy of the ` weather ` repository
1551562 . Delete any branches that are no longer necessary
156157
158+ The Owner can now:
159+
160+ 1 . Update their local copy of the ` weather ` repository
161+
157162::::::::::::::: solution
158163
159164## Solution
@@ -204,6 +209,16 @@ Deleted branch 3_shipping-forecast (was 17a1454).
204209
205210::::::::::::::::::::::::::::::::::::::::::::::::::
206211
212+ ::::::::::::::::::::::::::::::::::::::: challenge
213+
214+ ## Switch Roles and Repeat
215+
216+ Switch roles. Repeat the process of making changes
217+ on a feature branch and reviewing the changes
218+ (episodes [ 03] ( ./03-feature-branch.md ) and [ 04] ( ./04-review.md ) ).
219+
220+ ::::::::::::::::::::::::::::::::::::::::::::::::::
221+
207222:::::::::::::::::::::::::::::::::::::::: keypoints
208223
209224- A Pull Request (PR) is where your code and science review takes place.
0 commit comments