@@ -20,13 +20,14 @@ exercises: 10
20
20
21
21
In this section we will explore how to properly review
22
22
code and suggest changes if necessary.
23
- Head back to your own ` weather ` repository.
23
+ We will continue to work in pairs.
24
+ The Owner should navigate back to their own ` weather ` repository.
24
25
You should see an open PR from your Collaborator.
25
26
26
27
## Reviewing Changes
27
28
28
- Make sure you are on the PR your Collaborator has opened
29
- on the repository you own .
29
+ As the Owner make sure you are on the PR your Collaborator has opened
30
+ on your repository.
30
31
31
32
You can add general science and code review comments
32
33
in the ** Conversation** tab.
@@ -81,8 +82,7 @@ The PRs **Conversation** tab now looks like this:
81
82
82
83
## Responding to Review
83
84
84
- Make sure you are on the PR you opened
85
- on your Collaborators repository.
85
+ Now it is the Collaborators turn to respond to the review.
86
86
87
87
You can see merging is blocked because our reviewer has
88
88
requested changes. You also have the option to commit the
@@ -98,8 +98,7 @@ the suggested change as resolved.
98
98
99
99
## Approving Changes
100
100
101
- Make sure you are on the PR your Collaborator has opened
102
- on the repository you own.
101
+ Now the Owner can respond to the Collaborators final changes.
103
102
104
103
The Conversation tab should update to show the suggestion as
105
104
** Outdated** because it has been resolved by the Collaborator.
@@ -151,9 +150,15 @@ In the [git-novice](https://www.astropython.com/git-novice/10-pull-requests.html
151
150
lesson you learnt how to pull changes
152
151
and clean up your branches after merging a PR.
153
152
154
- 1 . Update your local copy of the ` weather ` repository
153
+ The Collaborator can now:
154
+
155
+ 1 . Update their local copy of the ` weather ` repository
155
156
2 . Delete any branches that are no longer necessary
156
157
158
+ The Owner can now:
159
+
160
+ 1 . Update their local copy of the ` weather ` repository
161
+
157
162
::::::::::::::: solution
158
163
159
164
## Solution
@@ -204,6 +209,16 @@ Deleted branch 3_shipping-forecast (was 17a1454).
204
209
205
210
::::::::::::::::::::::::::::::::::::::::::::::::::
206
211
212
+ ::::::::::::::::::::::::::::::::::::::: challenge
213
+
214
+ ## Switch Roles and Repeat
215
+
216
+ Switch roles. Repeat the process of making changes
217
+ on a feature branch and reviewing the changes
218
+ (episodes [ 03] ( ./03-feature-branch.md ) and [ 04] ( ./04-review.md ) ).
219
+
220
+ ::::::::::::::::::::::::::::::::::::::::::::::::::
221
+
207
222
:::::::::::::::::::::::::::::::::::::::: keypoints
208
223
209
224
- A Pull Request (PR) is where your code and science review takes place.
0 commit comments