Skip to content

Commit a4561af

Browse files
Clarify roles for the Collaborator and Owner
1 parent 76ba991 commit a4561af

File tree

2 files changed

+27
-9
lines changed

2 files changed

+27
-9
lines changed

episodes/03-feature-branch.md

+4-1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@ the Owner's repository.
2828
We will switch roles at the end, so both persons will
2929
play Owner and Collaborator.
3030

31+
While working together be sure to share what you
32+
are doing with your partner.
33+
3134
::::::::::::::::::::::::::::::::::::::::: callout
3235

3336
## Practicing By Yourself
@@ -195,7 +198,7 @@ In the git-novice lesson you practised opening a
195198

196199
You should see a notification appear on GitHub telling you the
197200
`3_shipping-forecast` branch had recent pushes.
198-
Click on the green **Compare & pull request** button to
201+
The Collaborator should click on the green **Compare & pull request** button to
199202
open the PR.
200203

201204
If you don't see this notification click on the branches dropdown

episodes/04-review.md

+23-8
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,14 @@ exercises: 10
2020

2121
In this section we will explore how to properly review
2222
code and suggest changes if necessary.
23-
Head back to your own `weather` repository.
23+
We will continue to work in pairs.
24+
The Owner should navigate back to their own `weather` repository.
2425
You should see an open PR from your Collaborator.
2526

2627
## Reviewing Changes
2728

28-
Make sure you are on the PR your Collaborator has opened
29-
on the repository you own.
29+
As the Owner make sure you are on the PR your Collaborator has opened
30+
on your repository.
3031

3132
You can add general science and code review comments
3233
in the **Conversation** tab.
@@ -81,8 +82,7 @@ The PRs **Conversation** tab now looks like this:
8182

8283
## Responding to Review
8384

84-
Make sure you are on the PR you opened
85-
on your Collaborators repository.
85+
Now it is the Collaborators turn to respond to the review.
8686

8787
You can see merging is blocked because our reviewer has
8888
requested changes. You also have the option to commit the
@@ -98,8 +98,7 @@ the suggested change as resolved.
9898

9999
## Approving Changes
100100

101-
Make sure you are on the PR your Collaborator has opened
102-
on the repository you own.
101+
Now the Owner can respond to the Collaborators final changes.
103102

104103
The Conversation tab should update to show the suggestion as
105104
**Outdated** because it has been resolved by the Collaborator.
@@ -151,9 +150,15 @@ In the [git-novice](https://www.astropython.com/git-novice/10-pull-requests.html
151150
lesson you learnt how to pull changes
152151
and clean up your branches after merging a PR.
153152

154-
1. Update your local copy of the `weather` repository
153+
The Collaborator can now:
154+
155+
1. Update their local copy of the `weather` repository
155156
2. Delete any branches that are no longer necessary
156157

158+
The Owner can now:
159+
160+
1. Update their local copy of the `weather` repository
161+
157162
::::::::::::::: solution
158163

159164
## Solution
@@ -204,6 +209,16 @@ Deleted branch 3_shipping-forecast (was 17a1454).
204209

205210
::::::::::::::::::::::::::::::::::::::::::::::::::
206211

212+
::::::::::::::::::::::::::::::::::::::: challenge
213+
214+
## Switch Roles and Repeat
215+
216+
Switch roles. Repeat the process of making changes
217+
on a feature branch and reviewing the changes
218+
(episodes [03](./03-feature-branch.md) and [04](./04-review.md)).
219+
220+
::::::::::::::::::::::::::::::::::::::::::::::::::
221+
207222
:::::::::::::::::::::::::::::::::::::::: keypoints
208223

209224
- A Pull Request (PR) is where your code and science review takes place.

0 commit comments

Comments
 (0)