You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardexpand all lines: episodes/04-review.md
+15
Original file line number
Diff line number
Diff line change
@@ -143,6 +143,21 @@ in the Version Control with Git lesson:
143
143
144
144
{alt='A screenshot of a PR showing the Conversations tab. The PR is ready to merge.'}
145
145
146
+
::: callout
147
+
148
+
## Who presses the merge button?
149
+
150
+
In this case both the contributor and reviewer have
151
+
write access to the repository.
152
+
This means they can both merge and close the PR
153
+
and it is up to your team to decide whether the contributor
154
+
or the reviewer does the merge as part of your working practices.
155
+
156
+
When using the forking model later the reviewer always
157
+
merges the PR as the contributor will not have sufficient permissions.
158
+
159
+
:::
160
+
146
161
When your PR is merged the Conversations tab will show:
147
162
148
163
{alt='A screenshot of a PR showing the Conversations tab. The notification tells us our PR has been successfully merged and closed.'}
0 commit comments