'mismatch' in UM Atmos and Recon compile options

[mcdalvi]

Hello,

A branch I am trying to lodge is failing rose stem build tasks (spice_gcc_nag , ex1a_gnu) due to argument mismatch errors in a routine for the recon executable only
I have not modified the routine in question, but possibly updated a module being USEd.

This seems to be due a difference in the compiler options used for the atmos and recon builds. The NAG options include -mismatch (-fallow-argument-mismatch for GNU) for the atmos build, but not for the recon builds.

Any guidance on how to proceed with the change ?

[james-bruten-mo]

Hi Mohit,

I think the atmos and recon-only builds both use the same fcm_make config files, so should have the same flags etc.
We have a number of --fallow-argument-mismatch's in the atmos config files. I guess it's likely that you need to add a file to there. The config files are in um_working_copy/fcm_make/meto-*/um-atmos-*.cfg.
I suspect we'd like to know why you need to add the new flag, just in case it's correctly identifying an issue in your new code.

[mcdalvi]

Thanks James.
However, the um-atmos executable is building, it is the reconf one that fails to build.
From : EXZ: ~mohit.dalvi/cylc-run/vn13.7_photol_fjx_api/share/fcm_make_ex1a_gnu_um_safe_noomp/fcm-make.log:

[info] shell(0  0.2) ftn -oo/fastjx_specs.o -c -I./include -fdefault-integer-8 -fdefault-real-8 -fdefault-double-8 -std=f2018 -g -I/common/umdir/lib/gnu-12.2.0/gcom/gcom-8.3/meto_ex1a_gfortran_mpp/build/include **-O1 -fallow-argument-mismatch** /var/spool/jtmp/6457231.exz00.jine3h3x/fcm_make_ex1a_gnu_um_safe_noomp.1.vn13.7_photol_fjx_apiq4WJ8d/preprocess-atmos/src/um/src/control/ukca_interface/fastjx_specs.F90
[>>&2] /var/spool/jtmp/6457231.exz00.jine3h3x/fcm_make_ex1a_gnu_um_safe_noomp.1.vn13.7_photol_fjx_apiq4WJ8d/**preprocess-atmos**/src/um/src/control/ukca_interface/fastjx_specs.F90:378:15:
[>>&2]
[>>&2]   371 | CALL mpl_bcast(n_solcyc_ts, 1, mpl_integer, 0, my_comm, icode)
[>>&2]       |               2
[>>&2] ......
[>>&2]   378 | CALL mpl_bcast(solcyc_ts, n_solcyc_ts, mpl_real, 0, my_comm, icode)[?4m
[>>&2]       |               1
[>>&2] Warning: Type mismatch between actual argument at (1) and actual argument at (2) (REAL(8)/INTEGER(8)).
---

[done] make build-atmos    # 104.5s
[init] make preprocess-recon# 2025-01-07T23:34:37Z

---
[FAIL] ftn -oo/fastjx_specs.o -c -I./include -fdefault-integer-8 -fdefault-real-8 -fdefault-double-8 -std=f2018 -g -I/common/umdir/lib/gnu-12.2.0/gcom/gcom-8.3/meto_ex1a_gfortran_mpp/build/include **-O1 -Werror** /var/spool/jtmp/6457231.exz00.jine3h3x/fcm_make_ex1a_gnu_um_safe_noomp.1.vn13.7_photol_fjx_apiq4WJ8d/preprocess-recon/src/um/src/control/ukca_interface/fastjx_specs.F90 # rc=1
[FAIL] /var/spool/jtmp/6457231.exz00.jine3h3x/fcm_make_ex1a_gnu_um_safe_noomp.1.vn13.7_photol_fjx_apiq4WJ8d/**preprocess-recon**/src/um/src/control/ukca_interface/fastjx_specs.F90:378:15:
[FAIL]
[FAIL]   371 | CALL mpl_bcast(n_solcyc_ts, 1, mpl_integer, 0, my_comm, icode)
[FAIL]       |               2
[FAIL] ......
[FAIL]   378 | CALL mpl_bcast(solcyc_ts, n_solcyc_ts, mpl_real, 0, my_comm, icode)
[FAIL]       |               1
[FAIL] Error: Type mismatch between actual argument at (1) and actual argument at (2) (REAL(8)/INTEGER(8)). >
...
[FAIL] make build-recon    # 18.3s 

[mcdalvi]

It may well be a bug, but I have not modified the routine here.
This is related to use of mpl_bcast to broadcast non-namelist type arrays, so will have to look for mpl_ or gc_ equivalents to introduce a proper fix.

[james-bruten-mo]

If you look in those fcm_make config files, eg the ex1a gnu safe you'll see $fcflags_override_mismatch being added to a load of files/directories in 2 sections, once for atmos and once for recon. You want to duplicate the fastjx_specs atmos line (line 24 in the link above) into the recon section. I assume it'll definitely need to be done for ex1a-gnu, azspice-gnu and any spice-gnu/gcc* files.

[mcdalvi]

Thanks, did not realise the recon settings were in the same file. I was looking for um-recon*.cfg files !

[mcdalvi]

For the record, I did try replacing the mpl_bcast calls for integer and real arrays with gc_ibcast, gc_rbcast. However the compilers still complain about MY_NAMELIST being passed to remaining mpl_bcast calls:
Argument 1 to MPL_BCAST has data type MY_NAMELIST in reference from FASTJX_RD_SOL and MY_NAMELIST in reference from FASTJX_RD_MIE

So, adding fastjx_specs with -fflags-override-mismatch to build-recon options in meto-x86-gcc and meto-ex1a-gnu (wherever atmos.prop was overriden for this file)