From d2d180059a62b8a4a07dc4ca22a4759c2e7546ea Mon Sep 17 00:00:00 2001 From: Charly Chevalier Date: Thu, 13 Feb 2025 22:56:38 +0100 Subject: [PATCH] fix: fix peer deps for `@metamask/{accounts,multichain-network}-controller` (#5327) ## Explanation The 2 controllers depend on each other, however we cannot really express this with peer deps. So for now, we only declare this "relation" on the new controller `mutltichain-network-controller`. Also downgrading some peer dep to use the major version. ## References N/A ## Changelog N/A ## Checklist - [ ] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes --------- Co-authored-by: Cal-L --- packages/accounts-controller/package.json | 6 +++--- packages/multichain-network-controller/package.json | 3 ++- yarn.lock | 7 ++++--- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/packages/accounts-controller/package.json b/packages/accounts-controller/package.json index 9260adcd99..0c6c3f7ac2 100644 --- a/packages/accounts-controller/package.json +++ b/packages/accounts-controller/package.json @@ -52,6 +52,7 @@ "@metamask/eth-snap-keyring": "^10.0.0", "@metamask/keyring-api": "^17.0.0", "@metamask/keyring-internal-api": "^4.0.1", + "@metamask/network-controller": "^22.2.1", "@metamask/snaps-sdk": "^6.17.1", "@metamask/snaps-utils": "^8.10.0", "@metamask/utils": "^11.1.0", @@ -63,7 +64,6 @@ "devDependencies": { "@metamask/auto-changelog": "^3.4.4", "@metamask/keyring-controller": "^19.1.0", - "@metamask/network-controller": "^22.2.1", "@metamask/providers": "^18.1.1", "@metamask/snaps-controllers": "^9.19.0", "@types/jest": "^27.4.1", @@ -76,8 +76,8 @@ "webextension-polyfill": "^0.12.0" }, "peerDependencies": { - "@metamask/keyring-controller": "^19.1.0", - "@metamask/network-controller": "^22.2.1", + "@metamask/keyring-controller": "^19.0.0", + "@metamask/network-controller": "^22.0.0", "@metamask/providers": "^18.1.0", "@metamask/snaps-controllers": "^9.19.0", "webextension-polyfill": "^0.10.0 || ^0.11.0 || ^0.12.0" diff --git a/packages/multichain-network-controller/package.json b/packages/multichain-network-controller/package.json index b8ba81573d..6fd4275f47 100644 --- a/packages/multichain-network-controller/package.json +++ b/packages/multichain-network-controller/package.json @@ -68,7 +68,8 @@ "typescript": "~5.2.2" }, "peerDependencies": { - "@metamask/network-controller": "^22.2.1" + "@metamask/accounts-controller": "^23.0.0", + "@metamask/network-controller": "^22.0.0" }, "engines": { "node": "^18.18 || >=20" diff --git a/yarn.lock b/yarn.lock index aa807d6b2b..dc8e1e4cfa 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2370,8 +2370,8 @@ __metadata: uuid: "npm:^8.3.2" webextension-polyfill: "npm:^0.12.0" peerDependencies: - "@metamask/keyring-controller": ^19.1.0 - "@metamask/network-controller": ^22.2.1 + "@metamask/keyring-controller": ^19.0.0 + "@metamask/network-controller": ^22.0.0 "@metamask/providers": ^18.1.0 "@metamask/snaps-controllers": ^9.19.0 webextension-polyfill: ^0.10.0 || ^0.11.0 || ^0.12.0 @@ -3475,7 +3475,8 @@ __metadata: typedoc-plugin-missing-exports: "npm:^2.0.0" typescript: "npm:~5.2.2" peerDependencies: - "@metamask/network-controller": ^22.2.1 + "@metamask/accounts-controller": ^23.0.0 + "@metamask/network-controller": ^22.0.0 languageName: unknown linkType: soft