Skip to content

Commit 4c41b3f

Browse files
remove getfeedback (#1947)
* remove getfeedback * remove GF_SURVEY_KEY --------- Co-authored-by: Alexandra Carrillo <[email protected]>
1 parent ae6fe8f commit 4c41b3f

File tree

10 files changed

+170
-320
lines changed

10 files changed

+170
-320
lines changed

.github/workflows/build.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,11 @@ on:
1010
required: true
1111
SENTRY_KEY:
1212
required: true
13-
GF_SURVEY_KEY:
14-
required: true
1513

1614
env:
1715
SEGMENT_ANALYTICS_KEY: ${{ secrets.SEGMENT_ANALYTICS_KEY }}
1816
LD_CLIENT_ID: ${{ secrets.LD_CLIENT_ID }}
1917
SENTRY_KEY: ${{ secrets.SENTRY_KEY }}
20-
GF_SURVEY_KEY: ${{ secrets.GF_SURVEY_KEY }}
2118

2219
jobs:
2320
build:

.github/workflows/case.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,22 +10,19 @@ on:
1010
required: true
1111
SENTRY_KEY:
1212
required: true
13-
GF_SURVEY_KEY:
14-
required: true
1513

1614
env:
1715
SEGMENT_ANALYTICS_KEY: ${{ secrets.SEGMENT_ANALYTICS_KEY }}
1816
LD_CLIENT_ID: ${{ secrets.LD_CLIENT_ID }}
1917
SENTRY_KEY: ${{ secrets.SENTRY_KEY }}
20-
GF_SURVEY_KEY: ${{ secrets.GF_SURVEY_KEY }}
2118

2219
jobs:
2320
case:
2421
name: Check for case being inconsistent
2522
runs-on: ubuntu-latest
2623
strategy:
2724
matrix:
28-
folder: ["docs"]
25+
folder: ['docs']
2926
permissions:
3027
contents: read
3128
steps:

.github/workflows/lint.yml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,11 @@ on:
1010
required: true
1111
SENTRY_KEY:
1212
required: true
13-
GF_SURVEY_KEY:
14-
required: true
1513

1614
env:
1715
SEGMENT_ANALYTICS_KEY: ${{ secrets.SEGMENT_ANALYTICS_KEY }}
1816
LD_CLIENT_ID: ${{ secrets.LD_CLIENT_ID }}
1917
SENTRY_KEY: ${{ secrets.SENTRY_KEY }}
20-
GF_SURVEY_KEY: ${{ secrets.GF_SURVEY_KEY }}
2118

2219
jobs:
2320
lint:
@@ -36,20 +33,20 @@ jobs:
3633
runs-on: ubuntu-latest
3734
strategy:
3835
matrix:
39-
file-extensions: [".md", ".mdx"]
36+
file-extensions: ['.md', '.mdx']
4037
steps:
4138
- uses: actions/checkout@v4
4239
- name: Vale
4340
uses: Consensys/docs-gha/spelling@main
4441
with:
45-
FILEPATHS: "snaps,services,wallet,developer-tools,docs"
42+
FILEPATHS: 'snaps,services,wallet,developer-tools,docs'
4643

4744
linkCheck:
4845
name: Link Checking
4946
runs-on: ubuntu-latest
5047
strategy:
5148
matrix:
52-
file-extensions: [".md", ".mdx"]
49+
file-extensions: ['.md', '.mdx']
5350
steps:
5451
- uses: actions/checkout@v4
5552
- name: LinkCheck

.github/workflows/main.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ jobs:
2626
SEGMENT_ANALYTICS_KEY: ${{ secrets.SEGMENT_ANALYTICS_DEV_KEY }}
2727
LD_CLIENT_ID: ${{ secrets.LD_CLIENT_ID }}
2828
SENTRY_KEY: ${{ secrets.SENTRY_KEY }}
29-
GF_SURVEY_KEY: ${{ secrets.GF_SURVEY_KEY }}
3029

3130
lint:
3231
name: Lint
@@ -35,7 +34,6 @@ jobs:
3534
SEGMENT_ANALYTICS_KEY: ${{ secrets.SEGMENT_ANALYTICS_DEV_KEY }}
3635
LD_CLIENT_ID: ${{ secrets.LD_CLIENT_ID }}
3736
SENTRY_KEY: ${{ secrets.SENTRY_KEY }}
38-
GF_SURVEY_KEY: ${{ secrets.GF_SURVEY_KEY }}
3937

4038
case:
4139
name: Case
@@ -44,7 +42,6 @@ jobs:
4442
SEGMENT_ANALYTICS_KEY: ${{ secrets.SEGMENT_ANALYTICS_DEV_KEY }}
4543
LD_CLIENT_ID: ${{ secrets.LD_CLIENT_ID }}
4644
SENTRY_KEY: ${{ secrets.SENTRY_KEY }}
47-
GF_SURVEY_KEY: ${{ secrets.GF_SURVEY_KEY }}
4845

4946
all-jobs-completed:
5047
name: All jobs completed

docusaurus.config.js

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ const config = {
4242
VERCEL_ENV: process.env.VERCEL_ENV,
4343
DASHBOARD_URL: process.env.DASHBOARD_URL || 'http://localhost:3000',
4444
SENTRY_KEY: process.env.SENTRY_KEY,
45-
GF_SURVEY_KEY: process.env.GF_SURVEY_KEY,
4645
LINEA_ENS_URL: process.env.LINEA_ENS_URL,
4746
},
4847

@@ -57,8 +56,6 @@ const config = {
5756
defer: true,
5857
'data-domain': 'docs.metamask.io',
5958
},
60-
{ src: '/js/feedback-script.js', defer: true, async: true },
61-
{ src: '/js/getfeedback.js', defer: true, async: true },
6259
],
6360

6461
markdown: {
@@ -296,16 +293,16 @@ const config = {
296293
href: 'https://github.com/MetaMask/metamask-docs',
297294
},
298295
{
299-
label: "MetaMask wallet GitHub",
300-
href: "https://github.com/MetaMask/metamask-extension/",
296+
label: 'MetaMask wallet GitHub',
297+
href: 'https://github.com/MetaMask/metamask-extension/',
301298
},
302299
{
303300
label: 'MetaMask SDK GitHub',
304301
href: 'https://github.com/MetaMask/metamask-sdk/',
305302
},
306303
{
307-
label: "MetaMask Mobile GitHub",
308-
href: "https://github.com/MetaMask/metamask-mobile",
304+
label: 'MetaMask Mobile GitHub',
305+
href: 'https://github.com/MetaMask/metamask-mobile',
309306
},
310307
{
311308
label: 'Snaps GitHub',

src/theme/DocItem/Layout/GetFeedback.jsx

Lines changed: 0 additions & 38 deletions
This file was deleted.

src/theme/DocItem/Layout/index.jsx

Lines changed: 25 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,55 +1,54 @@
1-
import React from "react";
2-
import clsx from "clsx";
3-
import { useWindowSize } from "@docusaurus/theme-common";
4-
import { useDoc } from '@docusaurus/plugin-content-docs/client';
5-
import DocItemPaginator from "@theme/DocItem/Paginator";
6-
import DocVersionBanner from "@theme/DocVersionBanner";
7-
import DocItemFooter from "@theme/DocItem/Footer";
8-
import DocItemTags from "@theme/DocItem/Tags";
9-
import DocItemTOCMobile from "@theme/DocItem/TOC/Mobile";
10-
import DocItemTOCDesktop from "@theme/DocItem/TOC/Desktop";
11-
import DocItemContent from "@theme/DocItem/Content";
12-
import DocBreadcrumbs from "@theme/DocBreadcrumbs";
13-
import styles from "./styles.module.css";
14-
import GetFeedback from "./GetFeedback.jsx";
1+
import React from 'react'
2+
import clsx from 'clsx'
3+
import { useWindowSize } from '@docusaurus/theme-common'
4+
import { useDoc } from '@docusaurus/plugin-content-docs/client'
5+
import DocItemPaginator from '@theme/DocItem/Paginator'
6+
import DocVersionBanner from '@theme/DocVersionBanner'
7+
import DocItemFooter from '@theme/DocItem/Footer'
8+
import DocItemTags from '@theme/DocItem/Tags'
9+
import DocItemTOCMobile from '@theme/DocItem/TOC/Mobile'
10+
import DocItemTOCDesktop from '@theme/DocItem/TOC/Desktop'
11+
import DocItemContent from '@theme/DocItem/Content'
12+
import DocBreadcrumbs from '@theme/DocBreadcrumbs'
13+
import styles from './styles.module.css'
1514
/**
1615
* Decide if the toc should be rendered, on mobile or desktop viewports
1716
*/
1817
function useDocTOC() {
19-
const { frontMatter, toc } = useDoc();
20-
const windowSize = useWindowSize();
21-
const hidden = frontMatter.hide_table_of_contents;
22-
const canRender = !hidden && toc.length > 0;
23-
const mobile = canRender ? <DocItemTOCMobile /> : undefined;
18+
const { frontMatter, toc } = useDoc()
19+
const windowSize = useWindowSize()
20+
const hidden = frontMatter.hide_table_of_contents
21+
const canRender = !hidden && toc.length > 0
22+
const mobile = canRender ? <DocItemTOCMobile /> : undefined
2423
const desktop =
25-
canRender && (windowSize === "desktop" || windowSize === "ssr") ? (
24+
canRender && (windowSize === 'desktop' || windowSize === 'ssr') ? (
2625
<DocItemTOCDesktop />
27-
) : undefined;
26+
) : undefined
2827
return {
2928
hidden,
3029
mobile,
3130
desktop,
32-
};
31+
}
3332
}
3433
export default function DocItemLayout({ children }) {
35-
const docTOC = useDocTOC();
34+
const docTOC = useDocTOC()
3635
return (
3736
<div className="row">
38-
<div className={clsx("col", !docTOC.hidden && styles.docItemCol)}>
37+
<div className={clsx('col', !docTOC.hidden && styles.docItemCol)}>
3938
<DocVersionBanner />
4039
<div className={styles.docItemContainer}>
4140
<article>
4241
<DocBreadcrumbs />
4342
<DocItemTags />
4443
{docTOC.mobile}
4544
<DocItemContent>{children}</DocItemContent>
46-
{/* <GetFeedback /> */}
45+
4746
<DocItemFooter />
4847
</article>
4948
<DocItemPaginator />
5049
</div>
5150
</div>
5251
{docTOC.desktop && <div className="col col--3">{docTOC.desktop}</div>}
5352
</div>
54-
);
53+
)
5554
}

0 commit comments

Comments
 (0)