Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @metamask/controllers > babel-runtime from direct dependencies #16719

Open
mikesposito opened this issue Nov 29, 2022 · 1 comment
Open
Assignees
Labels

Comments

@mikesposito
Copy link
Member

babel-runtime package is included in multiple @metamask/controllers' direct deps: It is unused but takes up bundle size.

@mikesposito mikesposito self-assigned this Nov 29, 2022
@mikesposito mikesposito changed the title Remove babel-runtime from direct dependencies Remove @metamask/controllers > babel-runtime from direct dependencies Nov 29, 2022
@github-actions github-actions bot added the stale issues and PRs marked as stale label Jul 20, 2023
@pedronfigueiredo pedronfigueiredo removed the stale issues and PRs marked as stale label Jul 20, 2023
@MetaMask MetaMask deleted a comment from github-actions bot Jul 20, 2023
@legobeat
Copy link
Contributor

legobeat commented Nov 20, 2023

babel-runtime is still used by ethjs packages and therefore also through eth-method-registry. Recent @metamask/ethjs forks remove the babel-runtime (peer)Dependency.

Below PRs aim at resolving this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants