chore(3663): removing the isMultichainVersion1Enabled feature flag, and corresponding dead code (#12831)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
- Step 1 **(done)**: remove code that ran in the feature flag OFF
scenario, confirm stuff runs as expected (manually and e2e)
- Step 2 **(done)**: remove any left over checks on the feature flags,
for examples checks that used only feature flag ON to render something
specific to that scenario
- Step 3 **(done)**: address unit test snapshots tests failing, all the
while using these snapshots to ensure expected behavior is maintained,
comparing a test that runs with FF OFF, to the existing snapshot on
main, this test should pass since FF OFF is the default, this a
baseline. Next, compare the snapshot generated from a FF ON test running
on the code with feature flag, to the snapshot generated once all the
dead code and feature flag code is removed, that test should pass since
FF ON becomes the default behavior once feature flag and dead code is
removed.
- Step 4 **(done)**: address unit tests that fail on things other than
snapshots, find out why they are failing
- Step 5 **(done)**: added coverage on new code (Sonar)

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
3. What is the improvement/solution?
-->

## **Related issues**

Contributes to:
https://github.com/MetaMask/MetaMask-planning/issues/3663

## **Manual testing steps**

1. Go to the in app browser and test-dapp
2. Connect to it
3. Click the top header in the in-app browser, confirm the expected
permissions as displaying.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

It's a refactoring, to the user it looks the same before and after.

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Author: EtherWizard33

app/components/Approvals/SwitchChainApproval/SwitchChainApproval.tsx

@@ -58,7 +58,6 @@ const SwitchChainApproval = () => {
         onConfirm={onConfirm}
         currentPageInformation={pageMeta}
         customNetworkInformation={approvalRequest?.requestData}
-        type={approvalRequest?.requestData?.type}
       />
     </ApprovalModal>
   );

app/components/UI/NetworkModal/__snapshots__/index.test.tsx.snap

@@ -186,7 +186,7 @@ exports[`NetworkDetails renders correctly 1`] = `
                     }
                   }
                 >
-                  Add Network
+                  Add Test Network
                 </Text>
               </View>
               <View
@@ -338,15 +338,15 @@ exports[`NetworkDetails renders correctly 1`] = `
                       style={
                         {
                           "color": "#141618",
-                          "fontFamily": "EuclidCircularB-Bold",
+                          "fontFamily": "EuclidCircularB-Medium",
                           "fontSize": 14,
-                          "fontWeight": "700",
+                          "fontWeight": "500",
                           "letterSpacing": 0,
                           "lineHeight": 22,
                         }
                       }
                     >
-                      Display name
+                      Currency symbol
                     </Text>
                     <Text
                       accessibilityRole="text"
@@ -362,54 +362,33 @@ exports[`NetworkDetails renders correctly 1`] = `
                         }
                       }
                     >
-                      Test Network
+                      TEST
                     </Text>
-                    <Text
-                      accessibilityRole="text"
-                      style={
-                        {
-                          "color": "#141618",
-                          "fontFamily": "EuclidCircularB-Bold",
-                          "fontSize": 14,
-                          "fontWeight": "700",
-                          "letterSpacing": 0,
-                          "lineHeight": 22,
-                        }
-                      }
-                    >
-                      Chain ID
-                    </Text>
-                    <Text
-                      accessibilityRole="text"
+                    <View
                       style={
                         {
-                          "color": "#141618",
-                          "fontFamily": "EuclidCircularB-Regular",
-                          "fontSize": 14,
-                          "fontWeight": "400",
-                          "letterSpacing": 0,
-                          "lineHeight": 22,
-                          "marginBottom": 8,
+                          "alignItems": "center",
+                          "flexDirection": "row",
+                          "gap": 8,
                         }
                       }
                     >
-                      1
-                    </Text>
-                    <Text
-                      accessibilityRole="text"
-                      style={
-                        {
-                          "color": "#141618",
-                          "fontFamily": "EuclidCircularB-Bold",
-                          "fontSize": 14,
-                          "fontWeight": "700",
-                          "letterSpacing": 0,
-                          "lineHeight": 22,
+                      <Text
+                        accessibilityRole="text"
+                        style={
+                          {
+                            "color": "#141618",
+                            "fontFamily": "EuclidCircularB-Medium",
+                            "fontSize": 14,
+                            "fontWeight": "500",
+                            "letterSpacing": 0,
+                            "lineHeight": 22,
+                          }
                         }
-                      }
-                    >
-                      Network URL
-                    </Text>
+                      >
+                        Network RPC URL
+                      </Text>
+                    </View>
                     <Text
                       accessibilityRole="text"
                       style={

app/components/UI/NetworkVerificationInfo/NetworkVerificationInfo.ff-on.test.tsx

@@ -1,6 +1,6 @@
 import React from 'react';
 import NetworkVerificationInfo from './NetworkVerificationInfo';
-import { render } from '@testing-library/react-native';
+import { render, fireEvent } from '@testing-library/react-native';
 import { BannerAlertSeverity } from '../../../component-library/components/Banners/Banner';
 import { strings } from '../../../../locales/i18n';
 import { useSelector } from 'react-redux';
@@ -85,7 +85,7 @@ describe('NetworkVerificationInfo', () => {
     ).toThrow('Unable to find an element with text');
   });
 
-  it('should render chainId on decimal', () => {
+  it('should render chainId as a decimal', () => {
     (useSelector as jest.Mock).mockReturnValue(true);
     const { getByText } = render(
       <NetworkVerificationInfo
@@ -95,6 +95,12 @@ describe('NetworkVerificationInfo', () => {
       />,
     );
 
+    // Accordion content is hidden by default, so we need to expand it
+    const accordionButton = getByText(
+      strings('spend_limit_edition.view_details'),
+    );
+    fireEvent.press(accordionButton);
+
     expect(getByText('10')).toBeTruthy();
   });