Skip to content

Commit 43ccab7

Browse files
chore(runway): cherry-pick fix: cp-7.42.0 enable notifications UI (#13906)
- fix: cp-7.42.0 enable notifications UI (#13877) ## **Description** Enable notifications for main (& the 7.42.0 release). ## **Related issues** ## **Manual testing steps** I'll be creating a QA doc for testing this feature (inc. demos). Enable/Disable Notifications Flow 1. Onboard wallet 2. Click Bell Icon > Click Enable Notifications - Expected: Notifications should become enabled. - NOTE - this may take a little while as we need to communicate to multiple services to register notifications for this user. 3. Visit Settings/Notifications > Click Disable Notifications - Expected: Notifications should become disabled. - NOTE - this may take a little while as we need to communicate to multiple services. Enable/Disable Push Notifications 1. Onboard + Enable Notifications 2. Visit Settings/Notifications 3. Toggle Push Notifications Enabled/Disabled. - Expected: This should toggle the switch (no other changes will occur in the UI). - NOTE - this may take a little while as we need to communicate to multiple services. Enable/Disable Feature Annonucements - N/A as there are no announcements released on Mobile (this will be fully tested post launch or in dev). Enable/Disable Account Notifications 1. Onboard + Enable Notifications 2. Visit Settings/Notifications 3. Toggle Account Notifications Enabled/Disabled. - Expected: This should toggle notifications on/off for your accounts. - NOTE - this may take a little while as we need to communicate to multiple services. We have plans to improve this flow (allow users to toggle multiple accounts and save changes). - NOTE - disabling notifications will also clear existing notifications in our DB, re-enabling account notifications will not return the previous notifications you may have had. Push Notifications: 1. Onboard + Enable Notifications + Enable Push Notifications + Ensure you have accounts with notifications enabled. 2. Minimise or close the app 3. In a different device, perform a send/swap on your account with notifications. - Expected: You should see push notifications on your mobile device - NOTE - push notifications are only send and our visible when the app is in the background or killed. Foreground notifications are not supported due to compatibility issues between IOS/Android (duplicate notification issues, notifications not showing due to device level properties). I've created a ticket to investigate this. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. [260866e](260866e) Co-authored-by: Prithpal Sooriya <[email protected]>
1 parent 4150502 commit 43ccab7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

bitrise.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1771,7 +1771,7 @@ app:
17711771
envs:
17721772
- opts:
17731773
is_expand: false
1774-
MM_NOTIFICATIONS_UI_ENABLED: false
1774+
MM_NOTIFICATIONS_UI_ENABLED: true
17751775
- opts:
17761776
is_expand: false
17771777
MM_NETWORK_UI_REDESIGN_ENABLED: false

0 commit comments

Comments
 (0)