Skip to content

Commit a1d4e5f

Browse files
authored
chore: remove SRP videos (#13507)
## **Description** Removing the SRP video (saving 7.5 mb) and replaced with new designs [here](https://www.figma.com/design/pViOUcmjwhEzFsdrwknpNc/Onboarding-redesign?node-id=1-117&t=SrTBBEz0dgAQsaoU-1) In the future we are doing a bigger redesign. This is a small step towards it ## **Related issues** Fixes: ## **Manual testing steps** 1. Fresh install of the app 2. Create a new wallet and going through onboarding flow, make sure the new design is there and fits on all devices 3. Afterwards goto settings and goto "Security and Privacy" to make sure its removed altogether (no design) ## **Screenshots/Recordings** ### Larger Devices iPhone 16 <img src="https://github.com/user-attachments/assets/a470060d-292f-46fc-acbe-2d3eea859557" width="250px" /> ### Smaller Devices iPhone SE https://github.com/user-attachments/assets/f2f45941-1b1d-4f2b-8151-c0028183f1f0 Pixel 2 <img src="https://github.com/user-attachments/assets/94ebea2e-100b-469a-afbc-f61369e2ee5f" width="250px" /> ### **Before** <img src="https://github.com/user-attachments/assets/a9c9011c-a466-4d1b-bcac-fcf930e1c5c1" width="250px" /> ### **After** <img src="https://github.com/user-attachments/assets/20f44bf9-17fe-440e-984e-69ce18a2b70f" width="250px" /> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent 0e2e044 commit a1d4e5f

26 files changed

+16
-1795
lines changed

app/components/UI/SeedPhraseVideo/index.js

Lines changed: 0 additions & 50 deletions
This file was deleted.

app/components/Views/AccountBackupStep1/__snapshots__/index.test.tsx.snap

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -775,17 +775,19 @@ exports[`AccountBackupStep1 should render correctly 1`] = `
775775
"fontSize": 24,
776776
"fontWeight": "600",
777777
"marginBottom": 24,
778+
"marginTop": 24,
778779
"textAlign": "center",
779780
}
780781
}
781782
>
782783
Secure your wallet
783784
</Text>
784-
<View
785+
<Image
786+
source={1}
785787
style={
786788
{
787-
"height": 240,
788-
"width": "100%",
789+
"height": 225,
790+
"width": 200,
789791
}
790792
}
791793
/>
@@ -805,7 +807,7 @@ exports[`AccountBackupStep1 should render correctly 1`] = `
805807
"fontSize": 14,
806808
"fontWeight": "400",
807809
"lineHeight": 20,
808-
"textAlign": "center",
810+
"textAlign": "left",
809811
}
810812
}
811813
>

app/components/Views/AccountBackupStep1/index.js

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import {
77
SafeAreaView,
88
StyleSheet,
99
BackHandler,
10+
Image,
1011
} from 'react-native';
1112
import PropTypes from 'prop-types';
1213
import { fontStyles } from '../../../styles/common';
@@ -22,7 +23,6 @@ import Engine from '../../../core/Engine';
2223
import { ONBOARDING_WIZARD } from '../../../constants/storage';
2324
import { CHOOSE_PASSWORD_STEPS } from '../../../constants/onboarding';
2425
import SkipAccountSecurityModal from '../../UI/SkipAccountSecurityModal';
25-
import SeedPhraseVideo from '../../UI/SeedPhraseVideo';
2626
import { connect } from 'react-redux';
2727
import setOnboardingWizardStep from '../../../actions/wizard';
2828
import { MetaMetricsEvents } from '../../../core/Analytics';
@@ -33,6 +33,7 @@ import { ManualBackUpStepsSelectorsIDs } from '../../../../e2e/selectors/Onboard
3333
import trackOnboarding from '../../../util/metrics/TrackOnboarding/trackOnboarding';
3434
import Routes from '../../../../app/constants/navigation/Routes';
3535
import { MetricsEventBuilder } from '../../../core/Analytics/MetricsEventBuilder';
36+
import SRPDesign from '../../../images/srp-lock-design.png';
3637

3738
const createStyles = (colors) =>
3839
StyleSheet.create({
@@ -59,6 +60,7 @@ const createStyles = (colors) =>
5960
title: {
6061
fontSize: 24,
6162
marginBottom: 24,
63+
marginTop: 24,
6264
color: colors.text.default,
6365
textAlign: 'center',
6466
...fontStyles.bold,
@@ -71,7 +73,7 @@ const createStyles = (colors) =>
7173
lineHeight: scaling.scale(20),
7274
fontSize: scaling.scale(14),
7375
color: colors.text.default,
74-
textAlign: 'center',
76+
textAlign: 'left',
7577
...fontStyles.normal,
7678
},
7779
buttonWrapper: {
@@ -115,6 +117,10 @@ const createStyles = (colors) =>
115117
ctaContainer: {
116118
marginBottom: 30,
117119
},
120+
srpDesign: {
121+
width: 200,
122+
height: 225,
123+
},
118124
});
119125

120126
/**
@@ -221,7 +227,8 @@ const AccountBackupStep1 = (props) => {
221227
<Text style={styles.title}>
222228
{strings('account_backup_step_1.title')}
223229
</Text>
224-
<SeedPhraseVideo onClose={skip} />
230+
231+
<Image source={SRPDesign} style={styles.srpDesign} />
225232
<View style={styles.text}>
226233
<Text style={styles.label}>
227234
{strings('account_backup_step_1.info_text_1_1')}{' '}

app/components/Views/Settings/SecuritySettings/Sections/ProtectYourWallet/ProtectYourWallet.tsx

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import Text, {
1010
TextVariant,
1111
TextColor,
1212
} from '../../../../../../component-library/components/Texts/Text';
13-
import SeedPhraseVideo from '../../../../../UI/SeedPhraseVideo';
1413
import { MetaMetricsEvents } from '../../../../../../core/Analytics';
1514
import { useTheme } from '../../../../../../util/theme';
1615
import { strings } from '../../../../../../../locales/i18n';
@@ -58,16 +57,11 @@ const ProtectYourWallet = ({
5857
);
5958
};
6059

61-
const onBack = (): void => navigation.goBack();
62-
6360
return (
6461
<View style={[styles.setting, styles.firstSetting]}>
6562
<Text variant={TextVariant.BodyLGMedium}>
6663
{strings('app_settings.protect_title')}
6764
</Text>
68-
<View style={styles.video}>
69-
<SeedPhraseVideo onClose={onBack} />
70-
</View>
7165

7266
<Text
7367
variant={TextVariant.BodyMD}

app/components/Views/Settings/SecuritySettings/Sections/ProtectYourWallet/styles.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,4 @@ export const createStyles = (colors: any) =>
3737
accessory: {
3838
marginTop: 16,
3939
},
40-
video: {
41-
marginTop: 16,
42-
},
4340
});

app/components/Views/Settings/SecuritySettings/__snapshots__/SecuritySettings.test.tsx.snap

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -76,22 +76,6 @@ exports[`SecuritySettings should render correctly 1`] = `
7676
>
7777
Protect your wallet
7878
</Text>
79-
<View
80-
style={
81-
{
82-
"marginTop": 16,
83-
}
84-
}
85-
>
86-
<View
87-
style={
88-
{
89-
"height": 240,
90-
"width": "100%",
91-
}
92-
}
93-
/>
94-
</View>
9579
<Text
9680
accessibilityRole="text"
9781
style={

app/images/srp-lock-design.png

69.1 KB
Loading

app/videos/README.md

Lines changed: 0 additions & 18 deletions
This file was deleted.

app/videos/recovery-phrase-source.mp4

-5.46 MB
Binary file not shown.

app/videos/recovery-phrase.mp4

-1.9 MB
Binary file not shown.

0 commit comments

Comments
 (0)