Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor header for tokens #11855

Merged
merged 25 commits into from
Feb 13, 2025
Merged

chore: refactor header for tokens #11855

merged 25 commits into from
Feb 13, 2025
+251 −135

Conversation

brianacnguyen
Copy link
Contributor

@brianacnguyen brianacnguyen commented Oct 17, 2024 •
edited
Loading

Description

This PR updates the Header for the Token details view, based on this design update by @amandaye0h . Specifically

  • Left and right button icons are now using the ButtonIcon component with the large size
  • Overflow icon is updated to vertical version
  • Alignment of header is now top aligned

Related issues

Fixes: #11854

Manual testing steps

  1. Go to Wallet
  2. Click on a token

Screenshots/Recordings

Before

Token 2 - Dark
Token 2 - Light

After

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-02-12.at.18.16.44.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-design-system All issues relating to design system in Mobile labels Oct 17, 2024
@brianacnguyen brianacnguyen self-assigned this Oct 17, 2024
@brianacnguyen brianacnguyen requested review from a team as code owners October 17, 2024 22:57
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@brianacnguyen brianacnguyen added the Run Smoke E2E Triggers smoke e2e on Bitrise label Oct 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 51ff159
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d2622345-500a-4fa4-8aa4-2f4db063b5db

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

georgewrmarshall
georgewrmarshall previously approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🚀 LGTM!

@brianacnguyen brianacnguyen added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 17, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 81e980e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4ac5b890-5d15-4de9-a01f-5bc7b74b2349

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@brianacnguyen brianacnguyen added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 17, 2024
@gambinish gambinish self-requested a review October 17, 2024 23:24
@brianacnguyen brianacnguyen requested review from a team as code owners October 17, 2024 23:44
@brianacnguyen brianacnguyen added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 17, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c824377
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/558854b7-7a10-4cae-aabb-59ebb5e2f924

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@brianacnguyen brianacnguyen added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Oct 18, 2024
@brianacnguyen brianacnguyen added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 18, 2024
@brianacnguyen brianacnguyen added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f74af71
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/36413755-1a46-4267-aaa2-6e0dec15b3bf

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
81.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@brianacnguyen brianacnguyen added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5f3b8df
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/450a5dec-0f65-4f1d-8259-fa09021cbbae

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@brianacnguyen brianacnguyen added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: b9c93d9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ce8dca31-ccc3-4cfd-a968-3692f04eb179

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
81.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

wachunei
wachunei approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@wachunei wachunei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ramp changes LGTM

nickewansmith
nickewansmith approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@nickewansmith nickewansmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stake changes LGTM

@brianacnguyen brianacnguyen added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit bff1503 Feb 13, 2025
45 checks passed
@brianacnguyen brianacnguyen deleted the header/tokendetails branch February 13, 2025 22:36
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 13, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
@metamaskbot metamaskbot added the release-7.42.0 Issue or pull request that will be included in release 7.42.0 label Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L left review comments

@wachunei wachunei wachunei approved these changes

@nickewansmith nickewansmith nickewansmith approved these changes

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

@vinnyhoward vinnyhoward vinnyhoward approved these changes

@gambinish gambinish gambinish approved these changes

Assignees

@brianacnguyen brianacnguyen

Labels
release-7.42.0 Issue or pull request that will be included in release 7.42.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-design-system All issues relating to design system in Mobile
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Design quality]: Update the mobile header to the design system header - Token details
9 participants
@brianacnguyen @vinnyhoward @gambinish @amitabh94 @wachunei @nickewansmith @georgewrmarshall @Cal-L @metamaskbot