Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Permit Simulation loader and value modal UI/UX #13398

Merged
merged 7 commits into from
Feb 13, 2025

Conversation

digiwand
Copy link
Contributor

@digiwand digiwand commented Feb 6, 2025

Description

Related issues

Fixes: #13337

Manual testing steps

  1. Go to https://develop.d3bkcslj57l47p.amplifyapp.com/
  2. Trigger Permit Batch

Screenshots/Recordings

Before

blue loading

modal label is not shown in subsequent simulation values:

CleanShot.2025-02-03.at.18.56.01.mp4

After

CleanShot.2025-02-07.at.01.12.24.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@digiwand digiwand requested a review from a team as a code owner February 6, 2025 23:11
Copy link
Contributor

github-actions bot commented Feb 6, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Feb 6, 2025
@digiwand digiwand changed the title Fix permit simulation modal and loader fix: Permit Simulation loader and value modal UI/UX Feb 6, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.56%. Comparing base (1937f9a) to head (f445c01).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13398      +/-   ##
==========================================
- Coverage   61.58%   61.56%   -0.02%     
==========================================
  Files        1953     1953              
  Lines       43442    43445       +3     
  Branches     5835     5834       -1     
==========================================
- Hits        26753    26749       -4     
- Misses      14905    14912       +7     
  Partials     1784     1784              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@digiwand digiwand added release-7.41.0 Issue or pull request that will be included in release 7.41.0 No E2E Smoke Needed If the PR does not need E2E smoke test run labels Feb 12, 2025
@digiwand digiwand added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 85c526b Feb 13, 2025
38 of 39 checks passed
@digiwand digiwand deleted the fix-permit-simulation-modal-and-loader branch February 13, 2025 10:25
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
No E2E Smoke Needed If the PR does not need E2E smoke test run release-7.41.0 Issue or pull request that will be included in release 7.41.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Permit Simulation UI/UX issues: blue loader and missing label change on values
4 participants