Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding navigation to confirmation pages #13461

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: adding navigation to confirmation pages #13461

wants to merge 10 commits into from

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Feb 12, 2025

Description

Add navigation for opening confirmation pages.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4143

Manual testing steps

  1. Go to test dapp
  2. Open signature pages and check navigation

Screenshots/Recordings

Dapp Requests:

Screen.Recording.2025-02-12.at.4.11.53.PM.mov

Staking:

Screen.Recording.2025-02-12.at.4.13.36.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Feb 12, 2025
@jpuri jpuri marked this pull request as ready for review February 12, 2025 16:50
@jpuri jpuri requested review from a team as code owners February 12, 2025 16:50
@jpuri jpuri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 13, 2025
Copy link
Contributor

github-actions bot commented Feb 13, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7aef35d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f2e0ded4-d3a4-4319-ba34-9a55de7df230

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants